netdev - Re: [PATCH net-next v2 1/5] dt-bindings: leds: add 'active-high' property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241014173715.08a2313d@kernel.org>
Date: Mon, 14 Oct 2024 17:37:15 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Daniel Golle <daniel@...rotopia.org>
Cc: Pavel Machek <pavel@....cz>, Lee Jones <lee@...nel.org>, Rob Herring
 <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Andrew Lunn <andrew@...n.ch>, Heiner Kallweit
 <hkallweit1@...il.com>, Russell King <linux@...linux.org.uk>, "David S.
 Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo
 Abeni <pabeni@...hat.com>, Xu Liang <lxu@...linear.com>, Christian Marangi
 <ansuelsmth@...il.com>, Bartosz Golaszewski
 <bartosz.golaszewski@...aro.org>, Robert Marko <robimarko@...il.com>,
 Russell King <rmk+kernel@...linux.org.uk>, Jacek Anaszewski
 <jacek.anaszewski@...il.com>, linux-leds@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 1/5] dt-bindings: leds: add 'active-high'
 property

On Thu, 10 Oct 2024 13:53:36 +0100 Daniel Golle wrote:
> Other than described in commit c94d1783136e ("dt-bindings: net: phy:
> Make LED active-low property common") the absence of the 'active-low'
> property means not to touch the polarity settings which are inherited
> from reset defaults, the bootloader or bootstrap configuration. Hence,
> in order to override a LED pin being active-high in case of the default,
> bootloader or bootstrap setting being active-low an additional property
> 'active-high' is required. Document that property and make it mutually
> exclusive to the existing 'active-low' property.

Daniel, please make sure you provide a cover letter for any submissions
longer than 2 patches. If nothing else it gives the maintainers a quick
overview of which files you're touching.

This submission is okay but please correct going forward.

Let's wait a bit longer for Lee to ack / take the first patch and then
I presume we take the rest.