netdev - Re: [PATCH net] netdevsim: macsec: pad u64 to correct length in logs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241015163521.3765bd68@kernel.org>
Date: Tue, 15 Oct 2024 16:35:21 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Ales Nezbeda <anezbeda@...hat.com>
Cc: netdev@...r.kernel.org, sd@...asysnail.net
Subject: Re: [PATCH net] netdevsim: macsec: pad u64 to correct length in
 logs

On Tue, 15 Oct 2024 13:09:43 +0200 Ales Nezbeda wrote:
> Currently, we pad u64 number to 8 characters using "%08llx" format
> specifier.
> 
> Changing format specifier to "%016llx" ensures that no matter the value
> the representation of number in log is always the same length.
> 
> Before this patch, entry in log for value '1' would say:
>     removing SecY with SCI 00000001 at index 2
> After this patch is applied, entry in log will say:
>     removing SecY with SCI 0000000000000001 at index 2
> 
> Fixes: 02b34d03a24b ("netdevsim: add dummy macsec offload")

padding prints in a test harness is not a fix so let's drop the Fixes
tag and repost against net-next
-- 
pw-bot: cr