netdev - Re: [PATCH net] net: systemport: fix potential memory leak in bcm_sysport

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d5a7d26c-982b-49cd-8bc9-2f2c535af2e2@broadcom.com>
Date: Tue, 15 Oct 2024 16:55:59 -0700
From: Florian Fainelli <florian.fainelli@...adcom.com>
To: Jakub Kicinski <kuba@...nel.org>,
 Florian Fainelli <florian.fainelli@...adcom.com>
Cc: Wang Hai <wanghai38@...wei.com>, bcm-kernel-feedback-list@...adcom.com,
 davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
 zhangxiaoxu5@...wei.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: systemport: fix potential memory leak in
 bcm_sysport_xmit()

On 10/15/24 12:54, Jakub Kicinski wrote:
> On Tue, 15 Oct 2024 11:07:29 -0700 Florian Fainelli wrote:
>>>> Since we already have a private counter tracking DMA mapping errors, I
>>>> would follow what the driver does elsewhere in the transmit path,
>>>> especially what bcm_sysport_insert_tsb() does, and just use
>>>> dev_consume_skb_any() here.
>>>
>>> Are you saying that if the packet drop is accounted is some statistics
>>> we should not inform drop monitor about it? 🤔️
>>> That wasn't my understanding of kfree_skb vs consume_skb..
>>
>> Yes that's my reasoning here, now given that we have had packet drops on
>> transmit that took forever to track down, maybe I better retract that
>> statement and go with v1.
> 
> Sounds good, we can apply v1. Would you like to ack/review here?
> 

Yes, now done, thanks!
-- 
Florian