netdev - Re: [PATCH net-next v3 9/9] Revert "net: do not leave a dangling sk pointer, when socket creation fails"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iJiic+opREJ3Q1nC6orXhJkSgAtSssOJeKip4ADYEsWPw@mail.gmail.com>
Date: Tue, 15 Oct 2024 10:06:59 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: ignat@...udflare.com, alex.aring@...il.com, alibuda@...ux.alibaba.com, 
	davem@...emloft.net, dsahern@...nel.org, johan.hedberg@...il.com, 
	kernel-team@...udflare.com, kuba@...nel.org, linux-bluetooth@...r.kernel.org, 
	linux-can@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-wpan@...r.kernel.org, luiz.dentz@...il.com, marcel@...tmann.org, 
	miquel.raynal@...tlin.com, mkl@...gutronix.de, netdev@...r.kernel.org, 
	pabeni@...hat.com, socketcan@...tkopp.net, stefan@...enfreihafen.org, 
	willemdebruijn.kernel@...il.com
Subject: Re: [PATCH net-next v3 9/9] Revert "net: do not leave a dangling sk
 pointer, when socket creation fails"

On Mon, Oct 14, 2024 at 11:42 PM Kuniyuki Iwashima <kuniyu@...zon.com> wrote:
>
> From: Ignat Korchagin <ignat@...udflare.com>
> Date: Mon, 14 Oct 2024 16:38:08 +0100
> > This reverts commit 6cd4a78d962bebbaf8beb7d2ead3f34120e3f7b2.
> >
> > inet/inet6->create() implementations have been fixed to explicitly NULL the
> > allocated sk object on error.
> >
> > A warning was put in place to make sure any future changes will not leave
> > a dangling pointer in pf->create() implementations.
> >
> > So this code is now redundant.
> >
> > Suggested-by: Kuniyuki Iwashima <kuniyu@...zon.com>
> > Signed-off-by: Ignat Korchagin <ignat@...udflare.com>
>
> Reviewed-by: Kuniyuki Iwashima <kuniyu@...zon.com>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>