netdev - Re: [PATCH v2 net-next 01/11] rtnetlink: Panic when __rtnl_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iLZVL4VGUh-=O+PJ8n+3agwOswu0QVDua4mp8RD5q4mQg@mail.gmail.com>
Date: Tue, 15 Oct 2024 10:13:00 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next 01/11] rtnetlink: Panic when
 __rtnl_register_many() fails for builtin callers.

On Mon, Oct 14, 2024 at 10:18 PM Kuniyuki Iwashima <kuniyu@...zon.com> wrote:
>
> We will replace all rtnl_register() and rtnl_register_module() with
> rtnl_register_many().
>
> Currently, rtnl_register() returns nothing and prints an error message
> when it fails to register a rtnetlink message type and handlers.
>
> The failure happens only when rtnl_register_internal() fails to allocate
> rtnl_msg_handlers[protocol][msgtype], but it's unlikely for built-in
> callers on boot time.
>
> rtnl_register_many() unwinds the previous successful registrations on
> failure and returns an error, but it will be useless for built-in callers,
> especially some subsystems that do not have the legacy ioctl() interface
> and do not work without rtnetlink.
>
> Instead of booting up without rtnetlink functionality, let's panic on
> failure for built-in rtnl_register_many() callers.
>
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...zon.com>
> ---

Reviewed-by: Eric Dumazet <edumazet@...gle.com>