[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID:
<PAXPR04MB8510FEE221C7B3B9FDB0801188462@PAXPR04MB8510.eurprd04.prod.outlook.com>
Date: Wed, 16 Oct 2024 07:38:58 +0000
From: Wei Fang <wei.fang@....com>
To: Simon Horman <horms@...nel.org>
CC: "davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com"
<edumazet@...gle.com>, "kuba@...nel.org" <kuba@...nel.org>,
"pabeni@...hat.com" <pabeni@...hat.com>, "robh@...nel.org" <robh@...nel.org>,
"krzk+dt@...nel.org" <krzk+dt@...nel.org>, "conor+dt@...nel.org"
<conor+dt@...nel.org>, Vladimir Oltean <vladimir.oltean@....com>, Claudiu
Manoil <claudiu.manoil@....com>, Clark Wang <xiaoning.wang@....com>, Frank Li
<frank.li@....com>, "christophe.leroy@...roup.eu"
<christophe.leroy@...roup.eu>, "linux@...linux.org.uk"
<linux@...linux.org.uk>, "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
"imx@...ts.linux.dev" <imx@...ts.linux.dev>, "netdev@...r.kernel.org"
<netdev@...r.kernel.org>, "devicetree@...r.kernel.org"
<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
<linux-kernel@...r.kernel.org>, "linux-pci@...r.kernel.org"
<linux-pci@...r.kernel.org>
Subject: RE: [PATCH v2 net-next 10/13] net: enetc: extract
enetc_int_vector_init/destroy() from enetc_alloc_msix()
>
> On Tue, Oct 15, 2024 at 08:58:38PM +0800, Wei Fang wrote:
> > drivers/net/ethernet/freescale/enetc/enetc.c | 174 +++++++++----------
> > 1 file changed, 87 insertions(+), 87 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/freescale/enetc/enetc.c
> b/drivers/net/ethernet/freescale/enetc/enetc.c
> > index 032d8eadd003..d36af3f8ba31 100644
> > --- a/drivers/net/ethernet/freescale/enetc/enetc.c
> > +++ b/drivers/net/ethernet/freescale/enetc/enetc.c
> > @@ -2965,6 +2965,87 @@ int enetc_ioctl(struct net_device *ndev, struct
> ifreq *rq, int cmd)
> > }
> > EXPORT_SYMBOL_GPL(enetc_ioctl);
> >
> > +static int enetc_int_vector_init(struct enetc_ndev_priv *priv, int i,
> > + int v_tx_rings)
> > +{
> > + struct enetc_int_vector *v __free(kfree);
> > + struct enetc_bdr *bdr;
> > + int j, err;
> > +
> > + v = kzalloc(struct_size(v, tx_ring, v_tx_rings), GFP_KERNEL);
> > + if (!v)
> > + return -ENOMEM;
>
> ...
>
> > int enetc_alloc_msix(struct enetc_ndev_priv *priv)
> > {
> > struct pci_dev *pdev = priv->si->pdev;
>
> ...
>
> > @@ -2986,64 +3067,9 @@ int enetc_alloc_msix(struct enetc_ndev_priv
> *priv)
> > /* # of tx rings per int vector */
> > v_tx_rings = priv->num_tx_rings / priv->bdr_int_num;
> >
> > - for (i = 0; i < priv->bdr_int_num; i++) {
> > - struct enetc_int_vector *v;
> > - struct enetc_bdr *bdr;
> > - int j;
> > -
> > - v = kzalloc(struct_size(v, tx_ring, v_tx_rings), GFP_KERNEL);
> > - if (!v) {
> > - err = -ENOMEM;
> > + for (i = 0; i < priv->bdr_int_num; i++)
> > + if (enetc_int_vector_init(priv, i, v_tx_rings))
> > goto fail;
>
> Hi Wei Fang,
>
> It looks like, if we reach this error handling during the first iteration
> of the for loop then err, which will be return value returned by the function,
> is ininitialised. Perhaps this would be better expressed as follows?
> (Completely untested!)
>
> err = enetc_int_vector_init(priv, i, v_tx_rings);
> if (err)
> goto fail;
>
> Flagged by Smatch.
>
Thanks, you are correct, I will fix it.
Powered by blists - more mailing lists