netdev - Re: [PATCH] eth: fbnic: add CONFIG_PTP_1588_CLOCK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <05861e8b-a26c-44f8-af47-50f31db1b720@linux.dev>
Date: Wed, 16 Oct 2024 08:46:34 +0100
From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To: Arnd Bergmann <arnd@...nel.org>, Alexander Duyck <alexanderduyck@...com>,
 Jakub Kicinski <kuba@...nel.org>, Andrew Lunn <andrew+netdev@...n.ch>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Paolo Abeni <pabeni@...hat.com>, Richard Cochran <richardcochran@...il.com>
Cc: Arnd Bergmann <arnd@...db.de>, kernel-team@...a.com,
 Simon Horman <horms@...nel.org>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] eth: fbnic: add CONFIG_PTP_1588_CLOCK_OPTIONAL dependency

On 16/10/2024 07:22, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> fbnic fails to link as built-in when PTP support is in a loadable
> module:
> 
> aarch64-linux-ld: drivers/net/ethernet/meta/fbnic/fbnic_ethtool.o: in function `fbnic_get_ts_info':
> fbnic_ethtool.c:(.text+0x428): undefined reference to `ptp_clock_index'
> aarch64-linux-ld: drivers/net/ethernet/meta/fbnic/fbnic_time.o: in function `fbnic_time_start':
> fbnic_time.c:(.text+0x820): undefined reference to `ptp_schedule_worker'
> aarch64-linux-ld: drivers/net/ethernet/meta/fbnic/fbnic_time.o: in function `fbnic_ptp_setup':
> fbnic_time.c:(.text+0xa68): undefined reference to `ptp_clock_register'
> 
> Add the appropriate dependency to enforce this.
> 
> Fixes: 6a2b3ede9543 ("eth: fbnic: add RX packets timestamping support")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Thanks!
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@...ux.dev>