netdev - Re: [PATCH net-next v4 4/6] Convert neighbour iteration to use hlist+macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241016091830.3507504-1-gnaaman@drivenets.com>
Date: Wed, 16 Oct 2024 09:18:30 +0000
From: Gilad Naaman <gnaaman@...venets.com>
To: kuniyu@...zon.com
Cc: davem@...emloft.net,
	edumazet@...gle.com,
	gnaaman@...venets.com,
	kuba@...nel.org,
	netdev@...r.kernel.org,
	pabeni@...hat.com
Subject: Re: [PATCH net-next v4 4/6] Convert neighbour iteration to use hlist+macro


> > @@ -427,6 +426,7 @@ static void neigh_flush_dev(struct neigh_table *tbl, struct net_device *dev,
> >  					n->nud_state = NUD_NONE;
> >  				neigh_dbg(2, "neigh %p is stray\n", n);
> >  			}
> > +			np = &n->next;
> >  			write_unlock(&n->lock);
> >  			neigh_cleanup_and_release(n);
> >  		}
> 
> Is this chunk necessary ?

Apologies, you're right.

I mixed up skipping with regular loop maintnance,
and thought I need to compensate for removing the original loop logic.
Obviously wrong in retrospect.