netdev - Re: net: phy: dp83822: Fix reset pin definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241016132911.0865f8bb@fedora.home>
Date: Wed, 16 Oct 2024 13:29:11 +0200
From: Maxime Chevallier <maxime.chevallier@...tlin.com>
To: Michel Alex <Alex.Michel@...demann-group.com>
Cc: Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>,
 Russell King <linux@...linux.org.uk>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
 <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Waibel Georg
 <Georg.Waibel@...demann-group.com>, Appelt Andreas
 <Andreas.Appelt@...demann-group.com>, "netdev@...r.kernel.org"
 <netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org"
 <linux-kernel@...r.kernel.org>
Subject: Re: net: phy: dp83822: Fix reset pin definitions

Hi,

On Wed, 16 Oct 2024 09:56:34 +0000
Michel Alex <Alex.Michel@...demann-group.com> wrote:

> The SW_RESET definition was incorrectly assigned to bit 14, which is the
> Digital Restart bit according to the datasheet. This commit corrects
> SW_RESET to bit 15 and assigns DIG_RESTART to bit 14 as per the
> datasheet specifications.
> 
> The SW_RESET define is only used in the phy_reset function, which fully
> re-initializes the PHY after the reset is performed. The change in the
> bit definitions should not have any negative impact on the functionality
> of the PHY.
> 
> Cc: mailto:stable@...r.kernel.org
> Signed-off-by: Alex Michel <mailto:alex.michel@...demann-group.com>

Thanks for the patch ! When submitting a patch for inclusion through
the net subsystem, you need to format your patch so that you indicate
whether the patch is aimed towards net-next (new features) or net
(bugfixes). More information can be found here :

https://www.kernel.org/doc/Documentation/process/maintainer-netdev.rst

You can use the --subject-prefix="PATCH net" option to git format-patch
when generating the patch.

It seems to me that this is indeed a bug, which has been reported
before :

https://lore.kernel.org/netdev/CAHvQdo2yzJC89K74c_CZFjPydDQ5i22w36XPR5tKVv_W8a2vcg@mail.gmail.com/

You would therefore need a Fixes tag pinpointing the commit that
introduced the issue :

Fixes: 5dc39fd5ef35 ("net: phy: DP83822: Add ability to advertise Fiber connection")

I don't have a board with that PHY to test it, it seems that issue of
the wrong bit being set during reset was introduced when Fiber support
for this PHY was added, it's unclear if the change was on purpose or
not and if changing this would break the boards that relies on straps
to detect that they are using Fiber :/

Best regards,

Maxime