[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20241016142135.GI2162@kernel.org>
Date: Wed, 16 Oct 2024 15:21:35 +0100
From: Simon Horman <horms@...nel.org>
To: Karan Sanghavi <karansanghvi98@...il.com>
Cc: Jamal Hadi Salim <jhs@...atatu.com>,
Cong Wang <xiyou.wangcong@...il.com>, Jiri Pirko <jiri@...nulli.us>,
netdev@...r.kernel.org, linux-kselftest@...r.kernel.org,
linux-kernel@...r.kernel.org,
Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v3] selftests: tc-testing: Fix spelling errors in
cgroup.json and flow.json
On Tue, Oct 15, 2024 at 05:00:06PM +0000, Karan Sanghavi wrote:
> This patch corrects typographical errors in the "name" fields of
> the JSON objects with IDs "4319" and "4341" in the tc-testing
> selftests.
>
> - "diffferent" is corrected to "different".
> - "muliple" is corrected to "multiple".
>
> Signed-off-by: Karan Sanghavi <karansanghvi98@...il.com>
> ---
>
> v3:
> - Corrected the change logs to make it easy to understand.
>
> v2:
> - Combine two earlier patches into one
> - Links to v1 of each patch
> [1] https://lore.kernel.org/all/Zqp9asVA-q_OzDP-@Emma/
> [2] https://lore.kernel.org/all/Zqp92oXa9joXk4T9@Emma/
>
> tools/testing/selftests/tc-testing/tc-tests/filters/cgroup.json | 2 +-
> tools/testing/selftests/tc-testing/tc-tests/filters/flow.json | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/tc-testing/tc-tests/filters/cgroup.json b/tools/testing/selftests/tc-testing/tc-tests/filters/cgroup.json
> index 03723cf84..6897ff5ad 100644
> --- a/tools/testing/selftests/tc-testing/tc-tests/filters/cgroup.json
> +++ b/tools/testing/selftests/tc-testing/tc-tests/filters/cgroup.json
> @@ -1189,7 +1189,7 @@
> },
> {
> "id": "4319",
> - "name": "Replace cgroup filter with diffferent match",
> + "name": "Replace cgroup filter with different match",
> "category": [
> "filter",
> "cgroup"
Hi Karan,
It seems that multiple is also misspelt several as miltiple in cgroup.json,
basic.json and route.json. While you are fixing spelling here could you fix
that too?
> diff --git a/tools/testing/selftests/tc-testing/tc-tests/filters/flow.json b/tools/testing/selftests/tc-testing/tc-tests/filters/flow.json
> index 58189327f..996448afe 100644
> --- a/tools/testing/selftests/tc-testing/tc-tests/filters/flow.json
> +++ b/tools/testing/selftests/tc-testing/tc-tests/filters/flow.json
> @@ -507,7 +507,7 @@
> },
> {
> "id": "4341",
> - "name": "Add flow filter with muliple ops",
> + "name": "Add flow filter with multiple ops",
> "category": [
> "filter",
> "flow"
> --
> 2.43.0
>
>
Powered by blists - more mailing lists