netdev - Re: [PATCH bpf v1 1/2] bpf: fix link info netfilter flags to populate defrag flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6383a2fe-e18e-46c0-86d7-eec597d5ef9e@iogearbox.net>
Date: Wed, 16 Oct 2024 17:13:22 +0200
From: Daniel Borkmann <daniel@...earbox.net>
To: Florian Westphal <fw@...len.de>, Tyrone Wu <wudevelops@...il.com>
Cc: bpf@...r.kernel.org, pablo@...filter.org, kadlec@...filter.org,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, andrii@...nel.org, eddyz87@...il.com, mykolal@...com,
 ast@...nel.org, martin.lau@...ux.dev, song@...nel.org,
 yonghong.song@...ux.dev, john.fastabend@...il.com, kpsingh@...nel.org,
 sdf@...ichev.me, haoluo@...gle.com, jolsa@...nel.org, shuah@...nel.org,
 riel@...riel.com, shakeel.butt@...ux.dev, netfilter-devel@...r.kernel.org,
 coreteam@...filter.org, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
 kernel-patches-bot@...com
Subject: Re: [PATCH bpf v1 1/2] bpf: fix link info netfilter flags to populate
 defrag flag

On 10/15/24 5:25 PM, Florian Westphal wrote:
> Tyrone Wu <wudevelops@...il.com> wrote:
>> This patch correctly populates the `bpf_link_info.netfilter.flags` field
>> when user passes the `BPF_F_NETFILTER_IP_DEFRAG` flag.
> 
> Indeed, thanks for fixing this.
> Patch and testcase look good, but one nit:
> 
>> Fixes: 84601d6ee68a ("bpf: add bpf_link support for BPF_NETFILTER programs")
> 
> BPF_F_NETFILTER_IP_DEFRAG flag was added in
> 91721c2d02d3 ("netfilter: bpf: Support BPF_F_NETFILTER_IP_DEFRAG in netfilter link"), that was a bit later than the initial support.
> 
> Other than that,
> Acked-by: Florian Westphal <fw@...len.de>

Thanks Florian & Tyrone, fixed up Fixes tag while applying.