[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20241016190046.GO2162@kernel.org>
Date: Wed, 16 Oct 2024 20:00:46 +0100
From: Simon Horman <horms@...nel.org>
To: Wang Hai <wanghai38@...wei.com>
Cc: ajit.khaparde@...adcom.com, sriharsha.basavapatna@...adcom.com,
somnath.kotur@...adcom.com, davem@...emloft.net,
edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
VenkatKumar.Duvvuru@...lex.com, zhangxiaoxu5@...wei.com,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 net] be2net: fix potential memory leak in be_xmit()
On Tue, Oct 15, 2024 at 10:48:02PM +0800, Wang Hai wrote:
> The be_xmit() returns NETDEV_TX_OK without freeing skb
> in case of be_xmit_enqueue() fails, add dev_kfree_skb_any() to fix it.
>
> Fixes: 760c295e0e8d ("be2net: Support for OS2BMC.")
> Signed-off-by: Wang Hai <wanghai38@...wei.com>
> ---
> v1->v2: Add label drop_skb for dev_kfree_skb_any()
Thanks for the update.
Reviewed-by: Simon Horman <horms@...nel.org>
Powered by blists - more mailing lists