netdev - Re: [PATCH v2 net-next 13/14] rtnetlink: Return int from rtnl_af

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241016231156.25855-1-kuniyu@amazon.com>
Date: Wed, 16 Oct 2024 16:11:56 -0700
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <dsahern@...nel.org>
CC: <davem@...emloft.net>, <edumazet@...gle.com>, <jk@...econstruct.com.au>,
	<kuba@...nel.org>, <kuni1840@...il.com>, <kuniyu@...zon.com>,
	<matt@...econstruct.com.au>, <netdev@...r.kernel.org>, <pabeni@...hat.com>,
	<razor@...ckwall.org>, <roopa@...dia.com>
Subject: Re: [PATCH v2 net-next 13/14] rtnetlink: Return int from rtnl_af_register().

From: David Ahern <dsahern@...nel.org>
Date: Wed, 16 Oct 2024 13:09:31 -0600
> On 10/16/24 12:53 PM, Kuniyuki Iwashima wrote:
> > diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c
> > index d81fff93d208..2152d8cfa2dc 100644
> > --- a/net/ipv4/devinet.c
> > +++ b/net/ipv4/devinet.c
> > @@ -2812,7 +2812,8 @@ void __init devinet_init(void)
> >  	register_pernet_subsys(&devinet_ops);
> >  	register_netdevice_notifier(&ip_netdev_notifier);
> >  
> > -	rtnl_af_register(&inet_af_ops);
> > +	if (rtnl_af_register(&inet_af_ops))
> > +		panic("Unable to register inet_af_ops\n");
> 
> why panic for IPv4 AF?

It's unlikely to fail to allocate memory for builtin during boot,
and I recently changed rtnl_register() to panic too, instead of
ignoring the errors.

https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=09aec57d8379