netdev - Re: [Intel-wired-lan] [PATCH v2 iwl-net 4/4] ice: Add correct PHY lane assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e2ed6973-cccb-46be-b847-3f18c85b3bf0@intel.com>
Date: Wed, 16 Oct 2024 16:29:18 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Karol Kolacinski <karol.kolacinski@...el.com>,
	<intel-wired-lan@...ts.osuosl.org>
CC: <netdev@...r.kernel.org>, Arkadiusz Kubalewski
	<Arkadiusz.kubalewski@...el.com>, <anthony.l.nguyen@...el.com>,
	<przemyslaw.kitszel@...el.com>
Subject: Re: [Intel-wired-lan] [PATCH v2 iwl-net 4/4] ice: Add correct PHY
 lane assignment



On 10/10/2024 7:21 AM, Karol Kolacinski wrote:

>  /**
>   * ice_ptp_init_phy_e825 - initialize PHY parameters
>   * @hw: pointer to the HW struct
> @@ -2743,8 +2723,6 @@ static void ice_ptp_init_phy_e825(struct ice_hw *hw)
>  	err = ice_read_phy_eth56g(hw, hw->pf_id, PHY_REG_REVISION, &phy_rev);
>  	if (err || phy_rev != PHY_REVISION_ETH56G)
>  		ptp->phy_model = ICE_PHY_UNSUP;
> -
> -	ptp->is_2x50g_muxed_topo = ice_is_muxed_topo(hw);
>  }
>  
Once we remove ptp->phy_model, this check for the PHY revision seems
like it is meaningless?

Thanks,
Jake