netdev - RE: [PATCH v2 net-next 02/13] dt-bindings: net: add i.MX95 ENETC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PAXPR04MB85101339DA552017EB19C39988462@PAXPR04MB8510.eurprd04.prod.outlook.com>
Date: Wed, 16 Oct 2024 02:06:36 +0000
From: Wei Fang <wei.fang@....com>
To: Rob Herring <robh@...nel.org>
CC: "davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "krzk+dt@...nel.org"
	<krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>, Vladimir
 Oltean <vladimir.oltean@....com>, Claudiu Manoil <claudiu.manoil@....com>,
	Clark Wang <xiaoning.wang@....com>, Frank Li <frank.li@....com>,
	"christophe.leroy@...roup.eu" <christophe.leroy@...roup.eu>,
	"linux@...linux.org.uk" <linux@...linux.org.uk>, "bhelgaas@...gle.com"
	<bhelgaas@...gle.com>, "horms@...nel.org" <horms@...nel.org>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-pci@...r.kernel.org"
	<linux-pci@...r.kernel.org>
Subject: RE: [PATCH v2 net-next 02/13] dt-bindings: net: add i.MX95 ENETC
 support

> -----Original Message-----
> From: Rob Herring <robh@...nel.org>
> Sent: 2024年10月16日 5:59
> To: Wei Fang <wei.fang@....com>
> Cc: davem@...emloft.net; edumazet@...gle.com; kuba@...nel.org;
> pabeni@...hat.com; krzk+dt@...nel.org; conor+dt@...nel.org; Vladimir
> Oltean <vladimir.oltean@....com>; Claudiu Manoil
> <claudiu.manoil@....com>; Clark Wang <xiaoning.wang@....com>; Frank Li
> <frank.li@....com>; christophe.leroy@...roup.eu; linux@...linux.org.uk;
> bhelgaas@...gle.com; horms@...nel.org; imx@...ts.linux.dev;
> netdev@...r.kernel.org; devicetree@...r.kernel.org;
> linux-kernel@...r.kernel.org; linux-pci@...r.kernel.org
> Subject: Re: [PATCH v2 net-next 02/13] dt-bindings: net: add i.MX95 ENETC
> support
> 
> On Tue, Oct 15, 2024 at 08:58:30PM +0800, Wei Fang wrote:
> > The ENETC of i.MX95 has been upgraded to revision 4.1, and the vendor
> > ID and device ID have also changed, so add the new compatible strings
> > for i.MX95 ENETC. In addition, i.MX95 supports configuration of RGMII
> > or RMII reference clock.
> >
> > Signed-off-by: Wei Fang <wei.fang@....com>
> > ---
> > v2 changes: remove "nxp,imx95-enetc" compatible string.
> > ---
> >  .../devicetree/bindings/net/fsl,enetc.yaml    | 19 +++++++++++++++----
> >  1 file changed, 15 insertions(+), 4 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/net/fsl,enetc.yaml
> b/Documentation/devicetree/bindings/net/fsl,enetc.yaml
> > index e152c93998fe..409ac4c09f63 100644
> > --- a/Documentation/devicetree/bindings/net/fsl,enetc.yaml
> > +++ b/Documentation/devicetree/bindings/net/fsl,enetc.yaml
> > @@ -20,14 +20,25 @@ maintainers:
> >
> >  properties:
> >    compatible:
> > -    items:
> > -      - enum:
> > -          - pci1957,e100
> > -      - const: fsl,enetc
> > +    oneOf:
> > +      - items:
> > +          - enum:
> > +              - pci1957,e100
> > +          - const: fsl,enetc
> > +      - items:
> 
> You can omit items here.
> 
> > +          - const: pci1131,e101
> >
> >    reg:
> >      maxItems: 1
> >
> > +  clocks:
> > +    items:
> > +      - description: MAC transmit/receiver reference clock
> > +
> > +  clock-names:
> > +    items:
> > +      - const: enet_ref_clk
> 
> Clock names are local to the block, so 'enet_' is redundant. It's all
> clock names, so '_clk' is redundant too. IOW, just use 'ref'.
>
Okay, I'll change its name.

> > +
> >    mdio:
> >      $ref: mdio.yaml
> >      unevaluatedProperties: false
> > --
> > 2.34.1
> >