netdev - Re: [PATCH net] mptcp: pm: fix UaF read in mptcp_pm_nl_rm_addr_or

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <172916043148.2424677.15397767732397939566.git-patchwork-notify@kernel.org>
Date: Thu, 17 Oct 2024 10:20:31 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Matthieu Baerts (NGI0) <matttbe@...nel.org>
Cc: mptcp@...ts.linux.dev, martineau@...nel.org, geliang@...nel.org,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org, stable@...r.kernel.org,
 syzbot+3c8b7a8e7df6a2a226ca@...kaller.appspotmail.com
Subject: Re: [PATCH net] mptcp: pm: fix UaF read in
 mptcp_pm_nl_rm_addr_or_subflow

Hello:

This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@...hat.com>:

On Tue, 15 Oct 2024 10:38:47 +0200 you wrote:
> Syzkaller reported this splat:
> 
>   ==================================================================
>   BUG: KASAN: slab-use-after-free in mptcp_pm_nl_rm_addr_or_subflow+0xb44/0xcc0 net/mptcp/pm_netlink.c:881
>   Read of size 4 at addr ffff8880569ac858 by task syz.1.2799/14662
> 
>   CPU: 0 UID: 0 PID: 14662 Comm: syz.1.2799 Not tainted 6.12.0-rc2-syzkaller-00307-g36c254515dc6 #0
>   Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2~bpo12+1 04/01/2014
>   Call Trace:
>    <TASK>
>    __dump_stack lib/dump_stack.c:94 [inline]
>    dump_stack_lvl+0x116/0x1f0 lib/dump_stack.c:120
>    print_address_description mm/kasan/report.c:377 [inline]
>    print_report+0xc3/0x620 mm/kasan/report.c:488
>    kasan_report+0xd9/0x110 mm/kasan/report.c:601
>    mptcp_pm_nl_rm_addr_or_subflow+0xb44/0xcc0 net/mptcp/pm_netlink.c:881
>    mptcp_pm_nl_rm_subflow_received net/mptcp/pm_netlink.c:914 [inline]
>    mptcp_nl_remove_id_zero_address+0x305/0x4a0 net/mptcp/pm_netlink.c:1572
>    mptcp_pm_nl_del_addr_doit+0x5c9/0x770 net/mptcp/pm_netlink.c:1603
>    genl_family_rcv_msg_doit+0x202/0x2f0 net/netlink/genetlink.c:1115
>    genl_family_rcv_msg net/netlink/genetlink.c:1195 [inline]
>    genl_rcv_msg+0x565/0x800 net/netlink/genetlink.c:1210
>    netlink_rcv_skb+0x165/0x410 net/netlink/af_netlink.c:2551
>    genl_rcv+0x28/0x40 net/netlink/genetlink.c:1219
>    netlink_unicast_kernel net/netlink/af_netlink.c:1331 [inline]
>    netlink_unicast+0x53c/0x7f0 net/netlink/af_netlink.c:1357
>    netlink_sendmsg+0x8b8/0xd70 net/netlink/af_netlink.c:1901
>    sock_sendmsg_nosec net/socket.c:729 [inline]
>    __sock_sendmsg net/socket.c:744 [inline]
>    ____sys_sendmsg+0x9ae/0xb40 net/socket.c:2607
>    ___sys_sendmsg+0x135/0x1e0 net/socket.c:2661
>    __sys_sendmsg+0x117/0x1f0 net/socket.c:2690
>    do_syscall_32_irqs_on arch/x86/entry/common.c:165 [inline]
>    __do_fast_syscall_32+0x73/0x120 arch/x86/entry/common.c:386
>    do_fast_syscall_32+0x32/0x80 arch/x86/entry/common.c:411
>    entry_SYSENTER_compat_after_hwframe+0x84/0x8e
>   RIP: 0023:0xf7fe4579
>   Code: b8 01 10 06 03 74 b4 01 10 07 03 74 b0 01 10 08 03 74 d8 01 00 00 00 00 00 00 00 00 00 00 00 00 00 51 52 55 89 e5 0f 34 cd 80 <5d> 5a 59 c3 90 90 90 90 8d b4 26 00 00 00 00 8d b4 26 00 00 00 00
>   RSP: 002b:00000000f574556c EFLAGS: 00000296 ORIG_RAX: 0000000000000172
>   RAX: ffffffffffffffda RBX: 000000000000000b RCX: 0000000020000140
>   RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000
>   RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000
>   R10: 0000000000000000 R11: 0000000000000296 R12: 0000000000000000
>   R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000
>    </TASK>
> 
> [...]

Here is the summary with links:
  - [net] mptcp: pm: fix UaF read in mptcp_pm_nl_rm_addr_or_subflow
    https://git.kernel.org/netdev/net/c/7decd1f5904a

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html