netdev - Re: [PATCH net-next v2] net: stmmac: Programming sequence for VLAN packets with split header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241017142533.GS1697@kernel.org>
Date: Thu, 17 Oct 2024 15:25:33 +0100
From: Simon Horman <horms@...nel.org>
To: Abhishek Chauhan <quic_abchauha@...cinc.com>
Cc: Alexandre Torgue <alexandre.torgue@...s.st.com>,
	Jose Abreu <joabreu@...opsys.com>,
	"David S . Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Maxime Coquelin <mcoquelin.stm32@...il.com>, netdev@...r.kernel.org,
	linux-stm32@...md-mailman.stormreply.com,
	linux-arm-kernel@...ts.infradead.org,
	Andrew Halaney <ahalaney@...hat.com>, Ong@...lcomm.com,
	Boon Leong <boon.leong.ong@...el.com>,
	Mohammad Athari Bin Ismail <mohammad.athari.ismail@...el.com>,
	Wong Vee Khee <vee.khee.wong@...ux.intel.com>,
	Tan Tee Min <tee.min.tan@...ux.intel.com>,
	Jon Hunter <jonathanh@...dia.com>, kernel@...cinc.com
Subject: Re: [PATCH net-next v2] net: stmmac: Programming sequence for VLAN
 packets with split header

On Wed, Oct 16, 2024 at 04:43:13PM -0700, Abhishek Chauhan wrote:
> Currently reset state configuration of split header works fine for
> non-tagged packets and we see no corruption in payload of any size
> 
> We need additional programming sequence with reset configuration to
> handle VLAN tagged packets to avoid corruption in payload for packets
> of size greater than 256 bytes.
> 
> Without this change ping application complains about corruption
> in payload when the size of the VLAN packet exceeds 256 bytes.
> 
> With this change tagged and non-tagged packets of any size works fine
> and there is no corruption seen.
> 
> Current configuration which has the issue for VLAN packet
> ----------------------------------------------------------
> 
> Split happens at the position at Layer 3 header
> |MAC-DA|MAC-SA|Vlan Tag|Ether type|IP header|IP data|Rest of the payload|
>                          2 bytes            ^
>                                             |
> 
> With the fix we are making sure that the split happens now at
> Layer 2 which is end of ethernet header and start of IP payload
> 
> Ip traffic split
> -----------------
> 
> Bits which take care of this are SPLM and SPLOFST
> SPLM = Split mode is set to Layer 2
> SPLOFST = These bits indicate the value of offset from the beginning
> of Length/Type field at which header split should take place when the
> appropriate SPLM is selected. Reset value is 2bytes.
> 
> Un-tagged data (without VLAN)
> |MAC-DA|MAC-SA|Ether type|IP header|IP data|Rest of the payload|
>                   2bytes ^
> 			 |
> 
> Tagged data (with VLAN)
> |MAC-DA|MAC-SA|VLAN Tag|Ether type|IP header|IP data|Rest of the payload|
>                           2bytes  ^
> 				  |
> 
> Non-IP traffic split such AV packet
> ------------------------------------
> 
> Bits which take care of this are
> SAVE = Split AV Enable
> SAVO = Split AV Offset, similar to SPLOFST but this is for AVTP
> packets.
> 
> |Preamble|MAC-DA|MAC-SA|VLAN tag|Ether type|IEEE 1722 payload|CRC|
> 				    2bytes ^
> 					   |
> 
> Signed-off-by: Abhishek Chauhan <quic_abchauha@...cinc.com>
> ---
> Changes since v1
> - took care of comments from Simon on FIELD_PREP
> - explained the details of l2 and l3 split as requested by Andrew
> - Added folks from intel and Nvidia who disabled split header
>   need to check if they faced similar issues and if this fix  
>   can help them too. 
> 
> Changes since v0
> - The reason for posting it on net-next is to enable this new feature.

Reviewed-by: Simon Horman <horms@...nel.org>