netdev - Re: [PATCH v2 2/2] pinctrl: qcom: add the tlmm driver for QCS8300 platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <abbea1df-4aaa-4012-95f9-ea1419a22414@quicinc.com>
Date: Thu, 17 Oct 2024 10:24:54 +0800
From: Jingyi Wang <quic_jingyw@...cinc.com>
To: Uwe Kleine-König <u.kleine-koenig@...libre.com>
CC: Bjorn Andersson <andersson@...nel.org>,
        Linus Walleij
	<linus.walleij@...aro.org>,
        Rob Herring <robh@...nel.org>,
        "Krzysztof
 Kozlowski" <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        "Richard
 Cochran" <richardcochran@...il.com>,
        <quic_tengfan@...cinc.com>, <quic_tingweiz@...cinc.com>,
        <quic_aiquny@...cinc.com>, <linux-arm-msm@...r.kernel.org>,
        <linux-gpio@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>
Subject: Re: [PATCH v2 2/2] pinctrl: qcom: add the tlmm driver for QCS8300
 platforms



On 10/16/2024 5:25 PM, Uwe Kleine-König wrote:
> Hello,
> 
> On Wed, Oct 09, 2024 at 03:13:34PM +0800, Jingyi Wang wrote:
>> +static struct platform_driver qcs8300_pinctrl_driver = {
>> +	.driver = {
>> +		.name = "qcs8300-tlmm",
>> +		.of_match_table = qcs8300_pinctrl_of_match,
>> +	},
>> +	.probe = qcs8300_pinctrl_probe,
>> +	.remove_new = msm_pinctrl_remove,
>> +};
> 
> After commit 0edb555a65d1 ("platform: Make platform_driver::remove()
> return void") .remove() is (again) the right callback to implement for
> platform drivers. Please just drop "_new".
> 
Will update that, thx!
> Best regards
> Uwe

Thanks,
Jingyi