netdev - Re: [PATCH net-next v1 0/5] net: stmmac: Refactor FPE as a separate module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241017170652.jtg2abm532sp4uah@skbuf>
Date: Thu, 17 Oct 2024 20:06:52 +0300
From: Vladimir Oltean <olteanv@...il.com>
To: Furong Xu <0x1207@...il.com>, Serge Semin <fancer.lancer@...il.com>
Cc: netdev@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Andrew Lunn <andrew@...n.ch>,
	Alexandre Torgue <alexandre.torgue@...s.st.com>,
	Jose Abreu <joabreu@...opsys.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Maxime Coquelin <mcoquelin.stm32@...il.com>, xfr@...look.com
Subject: Re: [PATCH net-next v1 0/5] net: stmmac: Refactor FPE as a separate
 module

On Tue, Oct 15, 2024 at 05:09:21PM +0800, Furong Xu wrote:
> Refactor FPE implementation by moving common code for DWMAC4 and
> DWXGMAC into a separate FPE module.
> 
> FPE implementation for DWMAC4 and DWXGMAC differs only for:
> 1) Offset address of MAC_FPE_CTRL_STS and MTL_FPE_CTRL_STS
> 2) FPRQ(Frame Preemption Residue Queue) field in MAC_RxQ_Ctrl1
> 
> Tested on DWMAC CORE 5.20a and DWXGMAC CORE 3.20a
> 
> Furong Xu (5):
>   net: stmmac: Introduce separate files for FPE implementation
>   net: stmmac: Introduce stmmac_fpe_ops for gmac4 and xgmac
>   net: stmmac: Rework marco definitions for gmac4 and xgmac
>   net: stmmac: xgmac: Rename XGMAC_RQ to XGMAC_FPRQ
>   net: stmmac: xgmac: Complete FPE support
> 
>  drivers/net/ethernet/stmicro/stmmac/Makefile  |   2 +-
>  drivers/net/ethernet/stmicro/stmmac/common.h  |   1 +
>  .../net/ethernet/stmicro/stmmac/dwmac4_core.c |  12 -
>  drivers/net/ethernet/stmicro/stmmac/dwmac5.c  | 150 ------
>  drivers/net/ethernet/stmicro/stmmac/dwmac5.h  |  26 --
>  .../net/ethernet/stmicro/stmmac/dwxgmac2.h    |   7 +-
>  .../ethernet/stmicro/stmmac/dwxgmac2_core.c   |  28 --
>  drivers/net/ethernet/stmicro/stmmac/hwif.c    |   7 +
>  drivers/net/ethernet/stmicro/stmmac/hwif.h    |  54 ++-
>  drivers/net/ethernet/stmicro/stmmac/stmmac.h  |  10 -
>  .../ethernet/stmicro/stmmac/stmmac_ethtool.c  |   2 +-
>  .../net/ethernet/stmicro/stmmac/stmmac_fpe.c  | 442 ++++++++++++++++++
>  .../net/ethernet/stmicro/stmmac/stmmac_fpe.h  |  38 ++
>  .../net/ethernet/stmicro/stmmac/stmmac_main.c | 149 +-----
>  .../net/ethernet/stmicro/stmmac/stmmac_tc.c   |   4 +-
>  15 files changed, 527 insertions(+), 405 deletions(-)
>  create mode 100644 drivers/net/ethernet/stmicro/stmmac/stmmac_fpe.c
>  create mode 100644 drivers/net/ethernet/stmicro/stmmac/stmmac_fpe.h
> 
> -- 
> 2.34.1
> 

Sergey Syomin is the one who originally requested the splitting of FPE
into a separate module.
https://lore.kernel.org/netdev/max7qd6eafatuse22ymmbfhumrctvf2lenwzhn6sxsm5ugebh6@udblqrtlblbf/

I guess you could CC him on next patch revisions, maybe he can take a
look and see if it is what he had in mind. I don't care so much about
internal stmmac organization stuff.