netdev - Re: [PATCH v1 net-next] ip6mr: Add __init to ip6_mr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c24b5c95-33b3-4501-ad5c-4315b29c4a18@intel.com>
Date: Thu, 17 Oct 2024 11:02:09 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>, "David S. Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, David Ahern
	<dsahern@...nel.org>
CC: Kuniyuki Iwashima <kuni1840@...il.com>, <netdev@...r.kernel.org>, "kernel
 test robot" <lkp@...el.com>
Subject: Re: [PATCH v1 net-next] ip6mr: Add __init to ip6_mr_cleanup().



On 10/17/2024 10:47 AM, Kuniyuki Iwashima wrote:
> kernel test robot reported a section mismatch in ip6_mr_cleanup().
> 
>   WARNING: modpost: vmlinux: section mismatch in reference: ip6_mr_cleanup+0x0 (section: .text) -> 0xffffffff (section: .init.rodata)
>   WARNING: modpost: vmlinux: section mismatch in reference: ip6_mr_cleanup+0x14 (section: .text) -> ip6mr_rtnl_msg_handlers (section: .init.rodata)
> 
> ip6_mr_cleanup() uses ip6mr_rtnl_msg_handlers[] that has
> __initconst_or_module qualifier.
> 
> ip6_mr_cleanup() is only called from inet6_init() but does
> not have __init qualifier.
> 
> Let's add __init to ip6_mr_cleanup().
> 
> Fixes: 3ac84e31b33e ("ipmr: Use rtnl_register_many().")
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202410180139.B3HeemsC-lkp@intel.com/
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...zon.com>
> ---

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>

>  net/ipv6/ip6mr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/ipv6/ip6mr.c b/net/ipv6/ip6mr.c
> index 437a9fdb67f5..8add0f45aa52 100644
> --- a/net/ipv6/ip6mr.c
> +++ b/net/ipv6/ip6mr.c
> @@ -1411,7 +1411,7 @@ int __init ip6_mr_init(void)
>  	return err;
>  }
>  
> -void ip6_mr_cleanup(void)
> +void __init ip6_mr_cleanup(void)
>  {
>  	rtnl_unregister_many(ip6mr_rtnl_msg_handlers);
>  #ifdef CONFIG_IPV6_PIMSM_V2