netdev - Re: [PATCH v4 1/6] octeontx2-pf: handle otx2_mbox_get_rsp errors in otx2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEKBCKPmRnpNGGws2FvmGCw5wnK+OvkyQzYYRJ+3JypuLp7OWA@mail.gmail.com>
Date: Fri, 18 Oct 2024 00:43:55 +0545
From: Dipendra Khadka <kdipendra88@...il.com>
To: Sunil Goutham <sgoutham@...vell.com>, Geetha sowjanya <gakula@...vell.com>, 
	Subbaraya Sundeep <sbhatta@...vell.com>, hariprasad <hkelam@...vell.com>, 
	Andrew Lunn <andrew+netdev@...n.ch>, "David S . Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.cocdm>, 
	pabeni@...hat.com
Cc: horms@...nel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/6] octeontx2-pf: handle otx2_mbox_get_rsp errors in otx2_common.c

+pabeni@...hat.com

On Fri, 18 Oct 2024 at 00:41, Dipendra Khadka <kdipendra88@...il.com> wrote:
>
> Add error pointer check after calling otx2_mbox_get_rsp().
>
> Fixes: ab58a416c93f ("octeontx2-pf: cn10k: Get max mtu supported from admin function")
> Signed-off-by: Dipendra Khadka <kdipendra88@...il.com>
> ---
> v4:
>  - Sent for patch version consistency.
> v3:https://lore.kernel.org/all/20241006164018.1820-1-kdipendra88@gmail.com/
>  - Included in the patch set
>  - Changed the patch subject
> v2: https://lore.kernel.org/all/20240923161738.4988-1-kdipendra88@gmail.com/
>  - Added Fixes: tag.
>  - Changed the return logic to follow the existing return path.
> v1: https://lore.kernel.org/all/20240923110633.3782-1-kdipendra88@gmail.com/
>  drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
> index 87d5776e3b88..7510a918d942 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
> @@ -1837,6 +1837,10 @@ u16 otx2_get_max_mtu(struct otx2_nic *pfvf)
>         if (!rc) {
>                 rsp = (struct nix_hw_info *)
>                        otx2_mbox_get_rsp(&pfvf->mbox.mbox, 0, &req->hdr);
> +               if (IS_ERR(rsp)) {
> +                       rc = PTR_ERR(rsp);
> +                       goto out;
> +               }
>
>                 /* HW counts VLAN insertion bytes (8 for double tag)
>                  * irrespective of whether SQE is requesting to insert VLAN
> --
> 2.43.0
>