netdev - Re: [PATCH v2] selftest/tcp-ao: Add filter tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJwJo6awAk0tG7RmorUBCTdnHx48Kdmztr=q_AgfhzBKox-zwA@mail.gmail.com>
Date: Thu, 17 Oct 2024 02:04:19 +0100
From: Dmitry Safonov <0x7f454c46@...il.com>
To: Leo Stone <leocstone@...il.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, 
	pabeni@...hat.com, shuah@...nel.org, rdunlap@...radead.org, 
	mnassiri@...na.com, jiapeng.chong@...ux.alibaba.com, colin.i.king@...il.com, 
	netdev@...r.kernel.org, linux-kselftest@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] selftest/tcp-ao: Add filter tests

On Wed, 16 Oct 2024 at 06:59, Leo Stone <leocstone@...il.com> wrote:
>
> Add tests that check if getsockopt(TCP_AO_GET_KEYS) returns the right
> keys when using different filters.
>
> Sample output:
>
> > # ok 114 filter keys: by sndid, rcvid, address
> > # ok 115 filter keys: by is_current
> > # ok 116 filter keys: by is_rnext
> > # ok 117 filter keys: by sndid, rcvid
> > # ok 118 filter keys: correct nkeys when in.nkeys < matched_keys
>
> Signed-off-by: Leo Stone <leocstone@...il.com>

LGTM, thank you!

Acked-by: Dmitry Safonov <0x7f454c46@...il.com>

> ---
> Changes in v2:
> - Changed 2 unnecessary test_error calls to test_fail
> - Added another test to make sure getsockopt returns the right nkeys
>   value when the input nkeys is smaller than the number of matching keys
> - Removed the TODO that this patch addresses
>
> Thank you for your feedback.
[..]

Thanks,
             Dmitry