netdev - Re: [PATCH net-next v9 23/23] testing/selftest: add test tool and scripts for ovpn module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <17a138ee-bdf8-467d-8f48-17e8a42d1ce2@openvpn.net>
Date: Thu, 17 Oct 2024 09:56:58 +0200
From: Antonio Quartulli <antonio@...nvpn.net>
To: Shuah Khan <skhan@...uxfoundation.org>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 openvpn-devel@...ts.sourceforge.net, linux-kselftest@...r.kernel.org,
 Paolo Abeni <pabeni@...hat.com>, Jakub Kicinski <kuba@...nel.org>,
 Eric Dumazet <edumazet@...gle.com>, Donald Hunter <donald.hunter@...il.com>,
 Shuah Khan <shuah@...nel.org>, sd@...asysnail.net, ryazanov.s.a@...il.com,
 Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH net-next v9 23/23] testing/selftest: add test tool and
 scripts for ovpn module

On 16/10/2024 23:14, Shuah Khan wrote:
> On 10/15/24 19:03, Antonio Quartulli wrote:
>> The ovpn-cli tool can be compiled and used as selftest for the ovpn
>> kernel module.
>>
>> It implements the netlink API and can thus be integrated in any
>> script for more automated testing.
>>
>> Along with the tool, 2 scripts are added that perform basic
>> functionality tests by means of network namespaces.
>>
>> The scripts can be performed in sequence by running run.sh
>>
>> Cc: shuah@...nel.org
>> Cc: linux-kselftest@...r.kernel.org
>> Signed-off-by: Antonio Quartulli <antonio@...nvpn.net>
> 
> I almost gave my Reviewed-by when I saw the very long argument parsing
> in the main() - please see comment below under main().
> 
> Let's simply the logic using getopt() - it is way too long and
> complex.
> 

[...]

> 
> This is loooong arguments parsing. What's the reason to not use getopt()
> Doesn't it simplify all ofthie logic?
> 
> I would like to see it simplified for maintainability.

This tool was originally very simple...then...this happened :-D

I agree getopt() could help making this whole function easier to read 
and maintain.

I will include this change in v10.

Thanks!

Regards,

-- 
Antonio Quartulli
OpenVPN Inc.