netdev - Re: [PATCH 5.15.y 5.10.y 5.4.y] wifi: mac80211: fix potential key use-after-free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2024101836-unsavory-snowdrift-1f2c@gregkh>
Date: Fri, 18 Oct 2024 10:50:42 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Sherry Yang <sherry.yang@...cle.com>
Cc: stable@...r.kernel.org, sashal@...nel.org, johannes@...solutions.net,
	davem@...emloft.net, kuba@...nel.org,
	linux-wireless@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH 5.15.y 5.10.y 5.4.y] wifi: mac80211: fix potential key
 use-after-free

On Tue, Oct 15, 2024 at 03:20:30PM -0700, Sherry Yang wrote:
> From: Johannes Berg <johannes.berg@...el.com>
> 
> [ Upstream commit 31db78a4923ef5e2008f2eed321811ca79e7f71b ]
> 
> When ieee80211_key_link() is called by ieee80211_gtk_rekey_add()
> but returns 0 due to KRACK protection (identical key reinstall),
> ieee80211_gtk_rekey_add() will still return a pointer into the
> key, in a potential use-after-free. This normally doesn't happen
> since it's only called by iwlwifi in case of WoWLAN rekey offload
> which has its own KRACK protection, but still better to fix, do
> that by returning an error code and converting that to success on
> the cfg80211 boundary only, leaving the error for bad callers of
> ieee80211_gtk_rekey_add().
> 
> Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
> Fixes: fdf7cb4185b6 ("mac80211: accept key reinstall without changing anything")
> Signed-off-by: Johannes Berg <johannes.berg@...el.com>
> Signed-off-by: Sasha Levin <sashal@...nel.org>
> [Sherry: bp to fix CVE-2023-52530, resolved minor conflicts in 
> net/mac80211/cfg.c because of context change due to missing commit
> 23a5f0af6ff4 ("wifi: mac80211: remove cipher scheme support")
> ccdde7c74ffd ("wifi: mac80211: properly implement MLO key handling")]
> Signed-off-by: Sherry Yang <sherry.yang@...cle.com>

Now queued up, thanks.

greg k-h