netdev - Re: [PATCH net-next v2] netdevsim: macsec: pad u64 to correct length in logs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241018085617.GB1697@kernel.org>
Date: Fri, 18 Oct 2024 09:56:17 +0100
From: Simon Horman <horms@...nel.org>
To: Ales Nezbeda <anezbeda@...hat.com>
Cc: netdev@...r.kernel.org, sd@...asysnail.net, kuba@...nel.org
Subject: Re: [PATCH net-next v2] netdevsim: macsec: pad u64 to correct length
 in logs

On Thu, Oct 17, 2024 at 03:19:33PM +0200, Ales Nezbeda wrote:
> Commit 02b34d03a24b ("netdevsim: add dummy macsec offload") pads u64
> number to 8 characters using "%08llx" format specifier.
> 
> Changing format specifier to "%016llx" ensures that no matter the value
> the representation of number in log is always the same length.
> 
> Before this patch, entry in log for value '1' would say:
>     removing SecY with SCI 00000001 at index 2
> After this patch is applied, entry in log will say:
>     removing SecY with SCI 0000000000000001 at index 2
> 
> Signed-off-by: Ales Nezbeda <anezbeda@...hat.com>
> ---
> v2
>   - Remove fixes tag and post against net-next
>   - v1 ref: https://lore.kernel.org/netdev/20241015110943.94217-1-anezbeda@redhat.com/

Thanks for the update.

Reviewed-by: Simon Horman <horms@...nel.org>