netdev - Re: [PATCH net-next v1] netlink: specs: Add missing bitset attrs to ethtool spec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241018110802.6e467882@kmaincent-XPS-13-7390>
Date: Fri, 18 Oct 2024 11:08:02 +0200
From: Kory Maincent <kory.maincent@...tlin.com>
To: Donald Hunter <donald.hunter@...il.com>
Cc: netdev@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>, "David S.
 Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo
 Abeni <pabeni@...hat.com>, donald.hunter@...hat.com
Subject: Re: [PATCH net-next v1] netlink: specs: Add missing bitset attrs to
 ethtool spec

On Fri, 18 Oct 2024 10:06:30 +0100
Donald Hunter <donald.hunter@...il.com> wrote:

> There are a couple of attributes missing from the 'bitset' attribute-set
> in the ethtool netlink spec. Add them to the spec.

Reviewed-by: Kory Maincent <kory.maincent@...tlin.com>
Tested-by: Kory Maincent <kory.maincent@...tlin.com>

Thank you!
 
> Reported-by: Kory Maincent <kory.maincent@...tlin.com>
> Closes:
> https://lore.kernel.org/netdev/20241017180551.1259bf5c@kmaincent-XPS-13-7390/
> Signed-off-by: Donald Hunter <donald.hunter@...il.com> ---
>  Documentation/netlink/specs/ethtool.yaml | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/netlink/specs/ethtool.yaml
> b/Documentation/netlink/specs/ethtool.yaml index 6a050d755b9c..f6c5d8214c7e
> 100644 --- a/Documentation/netlink/specs/ethtool.yaml
> +++ b/Documentation/netlink/specs/ethtool.yaml
> @@ -96,7 +96,12 @@ attribute-sets:
>          name: bits
>          type: nest
>          nested-attributes: bitset-bits
> -
> +      -
> +        name: value
> +        type: binary
> +      -
> +        name: mask
> +        type: binary
>    -
>      name: string
>      attributes:



-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com