netdev - Re: [PATCH v3 net-next 2/2] octeontx2-af: Knobs for NPC default rule counters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241018120159.GJ1697@kernel.org>
Date: Fri, 18 Oct 2024 13:01:59 +0100
From: Simon Horman <horms@...nel.org>
To: Linu Cherian <lcherian@...vell.com>
Cc: davem@...emloft.net, sgoutham@...vell.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, gakula@...vell.com,
	hkelam@...vell.com, sbhatta@...vell.com, jerinj@...vell.com,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	Jiri Pirko <jiri@...nulli.us>
Subject: Re: [PATCH v3 net-next 2/2] octeontx2-af: Knobs for NPC default rule
 counters

+ Jiri

On Thu, Oct 17, 2024 at 02:12:44PM +0530, Linu Cherian wrote:
> Add devlink knobs to enable/disable counters on NPC
> default rule entries.
> 
> Sample command to enable default rule counters:
> devlink dev param set <dev> name npc_def_rule_cntr value true cmode runtime
> 
> Sample command to read the counter:
> cat /sys/kernel/debug/cn10k/npc/mcam_rules
> 
> Signed-off-by: Linu Cherian <lcherian@...vell.com>
> ---
> Changelog from v2:
> Moved out the refactoring into separate patch. 
> 
>  .../net/ethernet/marvell/octeontx2/af/rvu.h   |  2 +
>  .../marvell/octeontx2/af/rvu_devlink.c        | 32 +++++++++++++
>  .../ethernet/marvell/octeontx2/af/rvu_npc.c   | 45 +++++++++++++++++++
>  3 files changed, 79 insertions(+)

Hi Linu,

This looks like a good approach to me.
However I think you also also need to add documentation for npc_def_rule_cntr
to Documentation/networking/devlink/octeontx2.rst

Likewise, octeontx2.rst seems to be missing documentation for the existing
AF parameters npc_mcam_high_zone_percent and nix_maxlf. I did not see
if there are any more undocumented parameters for octeontx2 but I'd
appreciate if you could do so.

...