netdev - Re: [PATCH v1 net-next 02/11] ipv4: Factorise RTM_NEWADDR validation to inet_validate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iJdZ0X1sor3f+WCcHt211ecaKq1-3=B0eHo1L=VEdp-JQ@mail.gmail.com>
Date: Fri, 18 Oct 2024 15:50:22 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, David Ahern <dsahern@...nel.org>, 
	Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v1 net-next 02/11] ipv4: Factorise RTM_NEWADDR validation
 to inet_validate_rtm().

On Fri, Oct 18, 2024 at 3:23 AM Kuniyuki Iwashima <kuniyu@...zon.com> wrote:
>
> rtm_to_ifaddr() validates some attributes, looks up a netdev,
> allocates struct in_ifaddr, and validates IFA_CACHEINFO.
>
> There is no reason to delay IFA_CACHEINFO validation.
>
> We will push RTNL down to inet_rtm_newaddr(), and then we want
> to complete rtnetlink validation before rtnl_net_lock().
>
> Let's factorise the validation parts.
>
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...zon.com>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>