[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CANn89iLzD21j3sQS24Db_YBrd5N2OEAAXrR03g+pHRfTXY5yEA@mail.gmail.com>
Date: Fri, 18 Oct 2024 15:56:53 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>
Cc: "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>, David Ahern <dsahern@...nel.org>,
Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v1 net-next 10/11] ipv4: Convert devinet_ioctl() to
per-netns RTNL except for SIOCSIFFLAGS.
On Fri, Oct 18, 2024 at 3:25 AM Kuniyuki Iwashima <kuniyu@...zon.com> wrote:
>
> Basically, devinet_ioctl() operates on a single netns.
>
> However, ioctl(SIOCSIFFLAGS) will trigger the netdev notifier
> that could touch another netdev in different netns.
>
> Let's use per-netns RTNL helper in devinet_ioctl() and place
> ASSERT_RTNL() for SIOCSIFFLAGS.
>
> We will remove ASSERT_RTNL() once RTM_SETLINK and RTM_DELLINK
> are converted.
>
> Signed-off-by: Kuniyuki Iwashima <kuniyu@...zon.com>
Reviewed-by: Eric Dumazet <edumazet@...gle.com>
Powered by blists - more mailing lists