netdev - Re: [PATCH net-next v3] net: Implement fault injection forcing skb reallocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAC5umygsk3NyPB99kdKtyV0xdpXihq-VRfzgua_8b40DexQ_QQ@mail.gmail.com>
Date: Sat, 19 Oct 2024 00:28:03 +0900
From: Akinobu Mita <akinobu.mita@...il.com>
To: Breno Leitao <leitao@...ian.org>
Cc: Jonathan Corbet <corbet@....net>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Andrew Morton <akpm@...ux-foundation.org>, kernel-team@...a.com, 
	Pavel Begunkov <asml.silence@...il.com>, Mina Almasry <almasrymina@...gle.com>, 
	Oleksij Rempel <o.rempel@...gutronix.de>, Kuniyuki Iwashima <kuniyu@...zon.com>, 
	Alexander Lobakin <aleksander.lobakin@...el.com>, 
	"open list:DOCUMENTATION" <linux-doc@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>, 
	"open list:NETWORKING [GENERAL]" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v3] net: Implement fault injection forcing skb reallocation

2024年10月14日(月) 22:50 Breno Leitao <leitao@...ian.org>:
> +static int __init skb_realloc_setup(char *str)
> +{
> +       return setup_fault_attr(&skb_realloc.attr, str);
> +}
> +__setup("skb_realloc=", skb_realloc_setup);

The documentation says "fail_net_force_skb_realloc=" boot option,
but this code seems to add "skb_realloc=" boot option.

I don't have a strong opinion about the naming, but I feel like
it's a bit long.  How about "fail_skb_realloc="?

The same goes for the debugfs directory name.

Reviewed-by: Akinobu Mita <akinobu.mita@...il.com>