netdev - Re: [PATCH] ipmr: Don't mark ip6mr_rtnl_msg_handlers as _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241018163100.88905-1-kuniyu@amazon.com>
Date: Fri, 18 Oct 2024 09:31:00 -0700
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <arnd@...nel.org>
CC: <aleksander.lobakin@...el.com>, <arnd@...db.de>, <chentao@...inos.cn>,
	<davem@...emloft.net>, <dsahern@...nel.org>, <edumazet@...gle.com>,
	<kuba@...nel.org>, <kuniyu@...zon.com>, <linux-kernel@...r.kernel.org>,
	<lizetao1@...wei.com>, <netdev@...r.kernel.org>, <pabeni@...hat.com>
Subject: Re: [PATCH] ipmr: Don't mark ip6mr_rtnl_msg_handlers as __initconst

From: Arnd Bergmann <arnd@...nel.org>
Date: Fri, 18 Oct 2024 15:12:14 +0000
> From: Arnd Bergmann <arnd@...db.de>
> 
> This gets referenced by the ip6_mr_cleanup function, so it must not be
> discarded early:
> 
> WARNING: modpost: vmlinux: section mismatch in reference: ip6_mr_cleanup+0x14 (section: .exit.text) -> ip6mr_rtnl_msg_handlers (section: .init.rodata)
> ERROR: modpost: Section mismatches detected.
> Set CONFIG_SECTION_MISMATCH_WARN_ONLY=y to allow them.
> 
> Fixes: 3ac84e31b33e ("ipmr: Use rtnl_register_many().")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Hi,

I posted this yesterday.
https://lore.kernel.org/netdev/20241017174732.39487-1-kuniyu@amazon.com/

Thanks


> ---
>  net/ipv6/ip6mr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/ipv6/ip6mr.c b/net/ipv6/ip6mr.c
> index 437a9fdb67f5..f7892afba980 100644
> --- a/net/ipv6/ip6mr.c
> +++ b/net/ipv6/ip6mr.c
> @@ -1367,7 +1367,7 @@ static struct pernet_operations ip6mr_net_ops = {
>  	.exit_batch = ip6mr_net_exit_batch,
>  };
>  
> -static const struct rtnl_msg_handler ip6mr_rtnl_msg_handlers[] __initconst_or_module = {
> +static const struct rtnl_msg_handler ip6mr_rtnl_msg_handlers[] = {
>  	{.owner = THIS_MODULE, .protocol = RTNL_FAMILY_IP6MR,
>  	 .msgtype = RTM_GETROUTE,
>  	 .doit = ip6mr_rtm_getroute, .dumpit = ip6mr_rtm_dumproute},
> -- 
> 2.39.5