netdev - Re: 回复: [PATCH] net: stmmac: enable MAC after MTL configuring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9a11c47e-0cd6-4741-a25b-68538763110a@lunn.ch>
Date: Fri, 18 Oct 2024 19:57:17 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Fan Hailong/范海龙 <hailong.fan@...ngine.com>
Cc: Simon Horman <horms@...nel.org>,
	"2694439648@...com" <2694439648@...com>,
	"alexandre.torgue@...s.st.com" <alexandre.torgue@...s.st.com>,
	"joabreu@...opsys.com" <joabreu@...opsys.com>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"edumazet@...gle.com" <edumazet@...gle.com>,
	"kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>,
	"mcoquelin.stm32@...il.com" <mcoquelin.stm32@...il.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-stm32@...md-mailman.stormreply.com" <linux-stm32@...md-mailman.stormreply.com>,
	"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: 回复: [PATCH] net: stmmac: enable
 MAC after MTL configuring

On Fri, Oct 18, 2024 at 01:15:30AM +0000, Fan Hailong/范海龙 wrote:
> Hi
> 
> For example, ETH is directly connected to the switch, which never power down and sends broadcast packets at regular intervals. 
> During the process of opening ETH, data may flow into the MTL FIFO, once MAC RX is enabled.
> and then, MTL will be set, such as FIFO size. 
> Once enable DMA, There is a certain probability that DMA will read incorrect data from MTL FIFO, causing DMA to hang up. 
> By read DMA_Debug_Status, you can be observed that the RPS remains at a certain value forever. 
> The correct process should be to configure MAC/MTL/DMA before enabling DMA/MAC

What Simon is asking for is that this is part of the commit message.

Please also don't top post.

    Andrew

---
pw-bot: cr