netdev - Re: [PATCH net-next 1/1] sched: Add dualpi2 qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202410190238.xwFjIctf-lkp@intel.com>
Date: Sat, 19 Oct 2024 02:45:03 +0800
From: kernel test robot <lkp@...el.com>
To: chia-yu.chang@...ia-bell-labs.com, netdev@...r.kernel.org,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, dsahern@...nel.org, ij@...nel.org,
	ncardwell@...gle.com, koen.de_schepper@...ia-bell-labs.com,
	g.white@...lelabs.com, ingemar.s.johansson@...csson.com,
	mirja.kuehlewind@...csson.com, cheshire@...le.com, rs.ietf@....at,
	Jason_Livingood@...cast.com, vidhi_goel@...le.com
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	Olga Albisser <olga@...isser.org>,
	Olivier Tilmans <olivier.tilmans@...ia.com>,
	Henrik Steen <henrist@...rist.net>,
	Bob Briscoe <research@...briscoe.net>,
	Chia-Yu Chang <chia-yu.chang@...ia-bell-labs.com>
Subject: Re: [PATCH net-next 1/1] sched: Add dualpi2 qdisc

Hi,

kernel test robot noticed the following build errors:

[auto build test ERROR on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/chia-yu-chang-nokia-bell-labs-com/sched-Add-dualpi2-qdisc/20241018-101154
base:   net-next/main
patch link:    https://lore.kernel.org/r/20241018021004.39258-2-chia-yu.chang%40nokia-bell-labs.com
patch subject: [PATCH net-next 1/1] sched: Add dualpi2 qdisc
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20241019/202410190238.xwFjIctf-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241019/202410190238.xwFjIctf-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410190238.xwFjIctf-lkp@intel.com/

All errors (new ones prefixed by >>):

>> net/sched/sch_dualpi2.c:536:12: error: call to undeclared function 'skb_sojourn_time'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     536 |                 qdelay = skb_sojourn_time(skb, now);
         |                          ^
   1 error generated.


vim +/skb_sojourn_time +536 net/sched/sch_dualpi2.c

   527	
   528	static int do_step_aqm(struct dualpi2_sched_data *q, struct sk_buff *skb,
   529			       u64 now)
   530	{
   531		u64 qdelay = 0;
   532	
   533		if (q->step.in_packets)
   534			qdelay = qdisc_qlen(q->l_queue);
   535		else
 > 536			qdelay = skb_sojourn_time(skb, now);
   537	
   538		if (dualpi2_skb_cb(skb)->apply_step && qdelay > q->step.thresh) {
   539			if (!dualpi2_skb_cb(skb)->ect)
   540				/* Drop this non-ECT packet */
   541				return 1;
   542			if (dualpi2_mark(q, skb))
   543				++q->step_marks;
   544		}
   545		qdisc_bstats_update(q->l_queue, skb);
   546		return 0;
   547	}
   548	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki