netdev - Re: [PATCH net-next] r8169: enable EEE at 2.5G per default on RTL8125B

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241018191410.GY1697@kernel.org>
Date: Fri, 18 Oct 2024 20:14:10 +0100
From: Simon Horman <horms@...nel.org>
To: Heiner Kallweit <hkallweit1@...il.com>
Cc: Realtek linux nic maintainers <nic_swsd@...ltek.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	Paolo Abeni <pabeni@...hat.com>, Jakub Kicinski <kuba@...nel.org>,
	David Miller <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] r8169: enable EEE at 2.5G per default on
 RTL8125B

On Thu, Oct 17, 2024 at 10:27:44PM +0200, Heiner Kallweit wrote:
> Register a6d/12 is shadowing register MDIO_AN_EEE_ADV2. So this line
> disables advertisement of EEE at 2.5G. Latest vendor driver r8125
> doesn't do this (any longer?), so this mode seems to be safe.
> EEE saves quite some energy, therefore enable this mode per default.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Reviewed-by: Simon Horman <horms@...nel.org>