netdev - RE: [PATCH v2 net 0/4] Fix passing 0 to ERR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CO1PR11MB508971C28F81B97F3A555F95D6402@CO1PR11MB5089.namprd11.prod.outlook.com>
Date: Fri, 18 Oct 2024 20:21:49 +0000
From: "Keller, Jacob E" <jacob.e.keller@...el.com>
To: Yue Haibing <yuehaibing@...wei.com>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, "davem@...emloft.net" <davem@...emloft.net>,
	"edumazet@...gle.com" <edumazet@...gle.com>, "kuba@...nel.org"
	<kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>, "ast@...nel.org"
	<ast@...nel.org>, "daniel@...earbox.net" <daniel@...earbox.net>,
	"hawk@...nel.org" <hawk@...nel.org>, "john.fastabend@...il.com"
	<john.fastabend@...il.com>, "Fijalkowski, Maciej"
	<maciej.fijalkowski@...el.com>, "vedang.patel@...el.com"
	<vedang.patel@...el.com>, "Joseph, Jithu" <jithu.joseph@...el.com>,
	"andre.guedes@...el.com" <andre.guedes@...el.com>, "horms@...nel.org"
	<horms@...nel.org>, "sven.auhagen@...eatech.de" <sven.auhagen@...eatech.de>,
	"alexander.h.duyck@...el.com" <alexander.h.duyck@...el.com>
CC: "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"bpf@...r.kernel.org" <bpf@...r.kernel.org>
Subject: RE: [PATCH v2 net 0/4] Fix passing 0 to ERR_PTR in intel ether
 drivers



> -----Original Message-----
> From: Yue Haibing <yuehaibing@...wei.com>
> Sent: Thursday, October 17, 2024 7:38 PM
> To: Nguyen, Anthony L <anthony.l.nguyen@...el.com>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@...el.com>; davem@...emloft.net; edumazet@...gle.com;
> kuba@...nel.org; pabeni@...hat.com; ast@...nel.org; daniel@...earbox.net;
> hawk@...nel.org; john.fastabend@...il.com; Fijalkowski, Maciej
> <maciej.fijalkowski@...el.com>; vedang.patel@...el.com; Joseph, Jithu
> <jithu.joseph@...el.com>; andre.guedes@...el.com; horms@...nel.org; Keller,
> Jacob E <jacob.e.keller@...el.com>; sven.auhagen@...eatech.de;
> alexander.h.duyck@...el.com
> Cc: intel-wired-lan@...ts.osuosl.org; netdev@...r.kernel.org; linux-
> kernel@...r.kernel.org; bpf@...r.kernel.org; yuehaibing@...wei.com
> Subject: [PATCH v2 net 0/4] Fix passing 0 to ERR_PTR in intel ether drivers
> 
> Fixing sparse error in xdp run code by introducing new variable xdp_res
> instead of overloading this into the skb pointer as i40e drivers done
> in commit 12738ac4754e ("i40e: Fix sparse errors in i40e_txrx.c") and
> commit ae4393dfd472 ("i40e: fix broken XDP support").
> 
> v2: Fix this as i40e drivers done instead of return NULL in xdp run code
> 

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>

Appreciate taking the time to fix all the cases.

> Yue Haibing (4):
>   igc: Fix passing 0 to ERR_PTR in igc_xdp_run_prog()
>   igb: Fix passing 0 to ERR_PTR in igb_run_xdp()
>   ixgbe: Fix passing 0 to ERR_PTR in ixgbe_run_xdp()
>   ixgbevf: Fix passing 0 to ERR_PTR in ixgbevf_run_xdp()
> 
>  drivers/net/ethernet/intel/igb/igb_main.c     | 22 +++++++-----------
>  drivers/net/ethernet/intel/igc/igc_main.c     | 20 ++++++----------
>  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 23 ++++++++-----------
>  .../net/ethernet/intel/ixgbevf/ixgbevf_main.c | 23 ++++++++-----------
>  4 files changed, 34 insertions(+), 54 deletions(-)
> 
> --
> 2.34.1
>