netdev - Re: [Intel-wired-lan] [PATCH iwl-next v11 09/14] libeth: move idpf_rx_csum_decoded and idpf_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46e34729-cf28-4c62-bc72-02cf68c4d43a@intel.com>
Date: Fri, 18 Oct 2024 15:31:37 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Mateusz Polchlopek <mateusz.polchlopek@...el.com>,
	<intel-wired-lan@...ts.osuosl.org>, <aleksander.lobakin@...el.com>
CC: <netdev@...r.kernel.org>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v11 09/14] libeth: move
 idpf_rx_csum_decoded and idpf_rx_extracted



On 10/13/2024 8:44 AM, Mateusz Polchlopek wrote:
> Structs idpf_rx_csum_decoded and idpf_rx_extracted are used both in
> idpf and iavf Intel drivers. Change the prefix from idpf_* to libeth_*
> and move mentioned structs to libeth's rx.h header file.
> 
> Adjust usage in idpf driver.
> 
> Suggested-by: Alexander Lobakin <aleksander.lobakin@...el.com>
> Signed-off-by: Mateusz Polchlopek <mateusz.polchlopek@...el.com>
> ---

This fails to compile:

> drivers/net/ethernet/intel/idpf/idpf_singleq_txrx.c: In function ‘idpf_rx_singleq_clean’:
> drivers/net/ethernet/intel/idpf/idpf_singleq_txrx.c:1040:78: error: expected ‘;’ before ‘napi_gro_receive’
>  1040 |                 idpf_rx_singleq_process_skb_fields(rx_q, skb, rx_desc, ptype)
>       |                                                                              ^
>       |                                                                              ;
> ......
>  1043 |                 napi_gro_receive(rx_q->pp->p.napi, skb);
>       |                 ~~~~~~~~~~~~~~~~

Thanks,
Jake