[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20241018-mctp-i2c-null-dest-v1-1-ba1ab52966e9@codeconstruct.com.au>
Date: Fri, 18 Oct 2024 11:07:56 +0800
From: Matt Johnston via B4 Relay <devnull+matt.codeconstruct.com.au@...nel.org>
To: Jeremy Kerr <jk@...econstruct.com.au>,
"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, stable@...r.kernel.org,
Dung Cao <dung@...amperecomputing.com>,
Matt Johnston <matt@...econstruct.com.au>
Subject: [PATCH net] mctp i2c: handle NULL header address
From: Matt Johnston <matt@...econstruct.com.au>
daddr can be NULL if there is no neighbour table entry present,
in that case the tx packet should be dropped.
Fixes: f5b8abf9fc3d ("mctp i2c: MCTP I2C binding driver")
Cc: stable@...r.kernel.org
Reported-by: Dung Cao <dung@...amperecomputing.com>
Signed-off-by: Matt Johnston <matt@...econstruct.com.au>
---
drivers/net/mctp/mctp-i2c.c | 3 +++
1 file changed, 3 insertions(+)
diff --git drivers/net/mctp/mctp-i2c.c drivers/net/mctp/mctp-i2c.c
index 4dc057c121f5..e70fb6687994 100644
--- drivers/net/mctp/mctp-i2c.c
+++ drivers/net/mctp/mctp-i2c.c
@@ -588,6 +588,9 @@ static int mctp_i2c_header_create(struct sk_buff *skb, struct net_device *dev,
if (len > MCTP_I2C_MAXMTU)
return -EMSGSIZE;
+ if (!daddr || !saddr)
+ return -EINVAL;
+
lldst = *((u8 *)daddr);
llsrc = *((u8 *)saddr);
---
base-commit: cb560795c8c2ceca1d36a95f0d1b2eafc4074e37
change-id: 20241018-mctp-i2c-null-dest-a0ba271e0c48
Best regards,
--
Matt Johnston <matt@...econstruct.com.au>
Powered by blists - more mailing lists