netdev - Re: [PATCH net-next v5 5/6] Remove bare neighbour::next pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202410181237.GEcWZ6xL-lkp@intel.com>
Date: Fri, 18 Oct 2024 12:56:25 +0800
From: kernel test robot <lkp@...el.com>
To: Gilad Naaman <gnaaman@...venets.com>, netdev <netdev@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Cc: oe-kbuild-all@...ts.linux.dev, Gilad Naaman <gnaaman@...venets.com>,
	Kuniyuki Iwashima <kuniyu@...zon.com>,
	Ido Schimmel <idosch@...dia.com>, Petr Machata <petrm@...dia.com>
Subject: Re: [PATCH net-next v5 5/6] Remove bare neighbour::next pointer

Hi Gilad,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Gilad-Naaman/Add-hlist_node-to-struct-neighbour/20241017-150629
base:   net-next/main
patch link:    https://lore.kernel.org/r/20241017070445.4013745-6-gnaaman%40drivenets.com
patch subject: [PATCH net-next v5 5/6] Remove bare neighbour::next pointer
config: x86_64-defconfig (https://download.01.org/0day-ci/archive/20241018/202410181237.GEcWZ6xL-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-12) 11.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241018/202410181237.GEcWZ6xL-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410181237.GEcWZ6xL-lkp@intel.com/

All warnings (new ones prefixed by >>):

   net/core/neighbour.c: In function 'neigh_remove_one':
>> net/core/neighbour.c:210:34: warning: variable 'nht' set but not used [-Wunused-but-set-variable]
     210 |         struct neigh_hash_table *nht;
         |                                  ^~~


vim +/nht +210 net/core/neighbour.c

   207	
   208	bool neigh_remove_one(struct neighbour *ndel, struct neigh_table *tbl)
   209	{
 > 210		struct neigh_hash_table *nht;
   211		bool retval = false;
   212	
   213		nht = rcu_dereference_protected(tbl->nht,
   214						lockdep_is_held(&tbl->lock));
   215	
   216		write_lock(&ndel->lock);
   217		if (refcount_read(&ndel->refcnt) == 1) {
   218			hlist_del_rcu(&ndel->hash);
   219			neigh_mark_dead(ndel);
   220			retval = true;
   221		}
   222		write_unlock(&ndel->lock);
   223		if (retval)
   224			neigh_cleanup_and_release(ndel);
   225		return retval;
   226	}
   227	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki