Message-ID: <4e1977ca-6166-4891-965e-34a6f319035f@leemhuis.info>
Date: Fri, 18 Oct 2024 07:30:07 +0200
From: Thorsten Leemhuis <regressions@...mhuis.info>
To: Luiz Augusto von Dentz <luiz.dentz@...il.com>, davem@...emloft.net,
 kuba@...nel.org
Cc: linux-bluetooth@...r.kernel.org, netdev@...r.kernel.org,
 Linus Torvalds <torvalds@...ux-foundation.org>,
 Linux kernel regressions list <regressions@...ts.linux.dev>,
 Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: pull request: bluetooth 2024-10-16

[CCing Linus, the two other -net maintainers, and the regressions lists]

On 16.10.24 22:42, Luiz Augusto von Dentz wrote:
> The following changes since commit 11d06f0aaef89f4cad68b92510bd9decff2d7b87:
> 
>   net: dsa: vsc73xx: fix reception from VLAN-unaware bridges (2024-10-15 18:41:52 -0700)
> 
> are available in the Git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git tags/for-net-2024-10-16

FWIW, from my point of view it would be nice if these changes could make
it to mainline this week. I know, they missed the weekly -net merge,
despite the quoted PR being sent on Wednesday (I assume it was too late
in the day). But the set contains a fix for a regression ("Bluetooth:
btusb: Fix not being able to reconnect after suspend") that to my
knowledge was reported and bisected at least *five* times already since
-rc1 (and the culprit recently hit 6.11.4 as well, so more people are
likely now affected by this :-/ ). Having "Bluetooth: btusb: Fix
regression with fake CSR controllers 0a12:0001" -mainlined rather sooner
that later would be nice, too, as it due to recent backports affects
afaics all stable series and iirc was reported at least two times
already (and who knows how many people are affected by those bugs that
never sat down to report them...).

Side note: I recently learned from one of Linus public mails (I can't
find right now on lore, sorry) why the -net subsystem is usually merging
mid-week. TBH from a regression point of view I have to say I don't like
it much, as bad timing with sub-subsystem PRs leads to situation like
the one described above. It is not the first time I notice one, but most
of the time I did not consider to write a mail about it.

Sure, telling sub-subsystems to send their PR earlier to the -net
maintainers could help, but even then we loose at least one or two days
(e.g. Wed and Thu) every week to get regression fixes mainlined before
the next -rc.

Ciao, Thorsten

> for you to fetch changes up to 2c1dda2acc4192d826e84008d963b528e24d12bc:
> 
>   Bluetooth: btusb: Fix regression with fake CSR controllers 0a12:0001 (2024-10-16 16:10:25 -0400)
> 
> ----------------------------------------------------------------
> bluetooth pull request for net:
> 
>  - ISO: Fix multiple init when debugfs is disabled
>  - Call iso_exit() on module unload
>  - Remove debugfs directory on module init failure
>  - btusb: Fix not being able to reconnect after suspend
>  - btusb: Fix regression with fake CSR controllers 0a12:0001
>  - bnep: fix wild-memory-access in proto_unregister
> 
> ----------------------------------------------------------------
> Aaron Thompson (3):
>       Bluetooth: ISO: Fix multiple init when debugfs is disabled
>       Bluetooth: Call iso_exit() on module unload
>       Bluetooth: Remove debugfs directory on module init failure
> 
> Luiz Augusto von Dentz (2):
>       Bluetooth: btusb: Fix not being able to reconnect after suspend
>       Bluetooth: btusb: Fix regression with fake CSR controllers 0a12:0001
> 
> Ye Bin (1):
>       Bluetooth: bnep: fix wild-memory-access in proto_unregister
> 
>  drivers/bluetooth/btusb.c    | 27 +++++++++------------------
>  net/bluetooth/af_bluetooth.c |  3 +++
>  net/bluetooth/bnep/core.c    |  3 +--
>  net/bluetooth/iso.c          |  6 +-----
>  4 files changed, 14 insertions(+), 25 deletions(-)

Powered by blists - more mailing lists