netdev - Re: [Intel-wired-lan] [PATCH net] igc: Fix passing 0 to ERR_PTR in igc_xdp_run

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87jze5udbd.fsf@kurt.kurt.home>
Date: Fri, 18 Oct 2024 08:37:10 +0200
From: Kurt Kanzenbach <kurt@...utronix.de>
To: Jacob Keller <jacob.e.keller@...el.com>, Maciej Fijalkowski
 <maciej.fijalkowski@...el.com>, Yue Haibing <yuehaibing@...wei.com>
Cc: Simon Horman <horms@...nel.org>, anthony.l.nguyen@...el.com,
 przemyslaw.kitszel@...el.com, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, ast@...nel.org, daniel@...earbox.net,
 hawk@...nel.org, john.fastabend@...il.com, vedang.patel@...el.com,
 andre.guedes@...el.com, jithu.joseph@...el.com,
 intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, bpf@...r.kernel.org
Subject: Re: [Intel-wired-lan] [PATCH net] igc: Fix passing 0 to ERR_PTR in
 igc_xdp_run_prog()

On Thu Oct 17 2024, Jacob Keller wrote:
> On 10/17/2024 4:03 AM, Maciej Fijalkowski wrote:
>> On Thu, Oct 17, 2024 at 11:55:05AM +0800, Yue Haibing wrote:
>>> On 2024/10/17 7:12, Jacob Keller wrote:
>>>> On 10/16/2024 4:06 PM, Jacob Keller wrote:
>>>>> I don't like this fix, I think we could drop the igc_xdp_run_prog
>>>>> wrapper, call __igc_xdp_run_prog directly and check its return value
>>>>> instead of this method of using an error pointer.
>>>>
>>>> Indeed, this SKB error stuff was added by 26575105d6ed ("igc: Add
>>>> initial XDP support") which claims to be aligning with other Intel drivers.
>>>>
>>>
>>> Thanks for review，maybe can fix this as commit 12738ac4754e ("i40e: Fix sparse errors in i40e_txrx.c")?
>> 
>> Yes please get rid of this logic. Historically speaking, i40e started this
>> and other drivers followed, but I chose in ice implementation to avoid
>> that :)
>
> Thanks!
>
>> 
>> Kurt, if you'll be sending next revision for igb xsk support, then avoid
>> the logic we talk about here as well, please.
>> 
> Yes, please fix this the way i40e did in the mentioned commit above.
> That looks significantly better to me :)

Changed the return type of igb_run_xdp_zc() from skb* to int.

Thanks,
Kurt

Download attachment "signature.asc" of type "application/pgp-signature" (862 bytes)