Message-ID: <1b59f661-4cdf-4951-9a44-cb4ef0cce2a2@leemhuis.info>
Date: Sun, 20 Oct 2024 17:30:19 +0200
From: "Linux regression tracking (Thorsten Leemhuis)"
 <regressions@...mhuis.info>
To: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: davem@...emloft.net, kuba@...nel.org, linux-bluetooth@...r.kernel.org,
 netdev@...r.kernel.org,
 Linux kernel regressions list <regressions@...ts.linux.dev>,
 Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 Luiz Augusto von Dentz <luiz.dentz@...il.com>
Subject: Re: pull request: bluetooth 2024-10-16

On 18.10.24 18:45, Luiz Augusto von Dentz wrote:
> On Fri, Oct 18, 2024 at 1:30 AM Thorsten Leemhuis
> <regressions@...mhuis.info> wrote:
>> On 16.10.24 22:42, Luiz Augusto von Dentz wrote:
>>> The following changes since commit 11d06f0aaef89f4cad68b92510bd9decff2d7b87:
>>>
>>>   net: dsa: vsc73xx: fix reception from VLAN-unaware bridges (2024-10-15 18:41:52 -0700)
>>>
>>> are available in the Git repository at:
>>>
>>>   git://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git tags/for-net-2024-10-16
>>
>> FWIW, from my point of view it would be nice if these changes could make
>> it to mainline this week. I know, they missed the weekly -net merge,
>> despite the quoted PR being sent on Wednesday (I assume it was too late
>> in the day). But the set contains a fix for a regression ("Bluetooth:
>> btusb: Fix not being able to reconnect after suspend") that to my
>> knowledge was reported and bisected at least *five* times already since
>> -rc1 (and the culprit recently hit 6.11.4 as well, so more people are
>> likely now affected by this :-/ ).

Meanwhile two more reports came it for this issue. And I became aware of
two more for the other Luiz mentioned. I noticed my chance that Fedora
became impatient and picked up both fixes.

>> Having "Bluetooth: btusb: Fix
>> regression with fake CSR controllers 0a12:0001" -mainlined rather sooner
>> that later would be nice, too, as it due to recent backports affects
>> afaics all stable series and iirc was reported at least two times
>> already (and who knows how many people are affected by those bugs that
>> never sat down to report them...).
> 
> +1
> 
> I really would like to send the PR sooner but being on the path of
> hurricane milton made things more complicated, anyway I think the most
> important ones are the regression fixes:

Linus, FWIW, in case you just those:

>       Bluetooth: btusb: Fix not being able to reconnect after suspend

That one is a2ce7481010a32 ("Bluetooth: btusb: Fix not being able to
reconnect after suspend") in -next and 4084286151fc91 in the PR above.
It was posted as
https://lore.kernel.org/all/20241014202326.381559-1-luiz.dentz@gmail.com/,
but Luiz at least fixed the Fixes: tag before committing the fix.

>       Bluetooth: btusb: Fix regression with fake CSR controllers 0a12:0001

That one is b29d4ac729754f ("Bluetooth: btusb: Fix regression with fake
CSR controllers 0a12:0001") in -next and 2c1dda2acc4192 in the PR above.
It was posted here:
https://lore.kernel.org/all/20241016154700.682621-1-luiz.dentz@gmail.com/
(not sure if there were any modifications afterwards).

Ciao, Thorsten

>> Side note: I recently learned from one of Linus public mails (I can't
>> find right now on lore, sorry) why the -net subsystem is usually merging
>> mid-week. TBH from a regression point of view I have to say I don't like
>> it much, as bad timing with sub-subsystem PRs leads to situation like
>> the one described above. It is not the first time I notice one, but most
>> of the time I did not consider to write a mail about it.
>>
>> Sure, telling sub-subsystems to send their PR earlier to the -net
>> maintainers could help, but even then we loose at least one or two days
>> (e.g. Wed and Thu) every week to get regression fixes mainlined before
>> the next -rc.
> 
> Yeah, that said I'm planning to switch to submit fixes more regularly
> (e.g weekly), which appears to be the cadence of the net tree, that
> way we narrow the window for landing fixes into linus tree.
> 
>> Ciao, Thorsten
>>
>>> for you to fetch changes up to 2c1dda2acc4192d826e84008d963b528e24d12bc:
>>>
>>>   Bluetooth: btusb: Fix regression with fake CSR controllers 0a12:0001 (2024-10-16 16:10:25 -0400)
>>>
>>> ----------------------------------------------------------------
>>> bluetooth pull request for net:
>>>
>>>  - ISO: Fix multiple init when debugfs is disabled
>>>  - Call iso_exit() on module unload
>>>  - Remove debugfs directory on module init failure
>>>  - btusb: Fix not being able to reconnect after suspend
>>>  - btusb: Fix regression with fake CSR controllers 0a12:0001
>>>  - bnep: fix wild-memory-access in proto_unregister
>>>
>>> ----------------------------------------------------------------
>>> Aaron Thompson (3):
>>>       Bluetooth: ISO: Fix multiple init when debugfs is disabled
>>>       Bluetooth: Call iso_exit() on module unload
>>>       Bluetooth: Remove debugfs directory on module init failure
>>>
>>> Luiz Augusto von Dentz (2):
>>>       Bluetooth: btusb: Fix not being able to reconnect after suspend
>>>       Bluetooth: btusb: Fix regression with fake CSR controllers 0a12:0001
>>>
>>> Ye Bin (1):
>>>       Bluetooth: bnep: fix wild-memory-access in proto_unregister
>>>
>>>  drivers/bluetooth/btusb.c    | 27 +++++++++------------------
>>>  net/bluetooth/af_bluetooth.c |  3 +++
>>>  net/bluetooth/bnep/core.c    |  3 +--
>>>  net/bluetooth/iso.c          |  6 +-----
>>>  4 files changed, 14 insertions(+), 25 deletions(-)
>>
> 
> 

Powered by blists - more mailing lists