netdev - Re: [PATCH bpf-next v2 0/3] XDP metadata: Rx checksum/GSO hint; Tx GSO offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJ8uoz0FcDP_ox_sRbG7ZJ=F70uJsALF-fGzW6snTQPXez_PXw@mail.gmail.com>
Date: Mon, 21 Oct 2024 14:04:43 +0200
From: Magnus Karlsson <magnus.karlsson@...il.com>
To: Willem de Bruijn <willemdebruijn.kernel@...il.com>
Cc: Stanislav Fomichev <stfomichev@...il.com>, Muyang Tian <tianmuyang@...wei.com>, bpf@...r.kernel.org, 
	"David S . Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Donald Hunter <donald.hunter@...il.com>, Björn Töpel <bjorn@...nel.org>, 
	Magnus Karlsson <magnus.karlsson@...el.com>, 
	Maciej Fijalkowski <maciej.fijalkowski@...el.com>, Jonathan Lemon <jonathan.lemon@...il.com>, 
	Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, 
	Jesper Dangaard Brouer <hawk@...nel.org>, John Fastabend <john.fastabend@...il.com>, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org, yanan@...wei.com, 
	xiesongyang@...wei.com, wuchangye@...wei.com, liuxin350@...wei.com, 
	zhangmingyi5@...wei.com, liwei883@...wei.com, willemb@...gle.com
Subject: Re: [PATCH bpf-next v2 0/3] XDP metadata: Rx checksum/GSO hint; Tx
 GSO offload

On Sun, 20 Oct 2024 at 22:51, Willem de Bruijn
<willemdebruijn.kernel@...il.com> wrote:
>
> Stanislav Fomichev wrote:
> > On 10/18, Muyang Tian wrote:
> > > This series introduce XDP metadata functionality, including Rx checksum/GSO hint
> > > and Tx GSO offload. This is aimed to transfer control fields when processing jumbo
> > > frames between VMs.
> >
> > Ideally, the series should also have the implementation of these hints
> > for a couple of devices and appropriate selftest updates to exercise
> > them.
>
> +1

Larysa had one implementation for ice [0]. Ask her if she can update
and contribute that one. Then add one yourself and there are two
implementations which would hopefully make the case.

[0] https://lore.kernel.org/bpf/20230811161509.19722-1-larysa.zaremba@intel.com/

> > For GSO, CC Willem going forward (I don't think I understand why
> > we want to have gso_type in the TX hint; something like header_len
> > seems like a better fit).
>
> GSO on Tx makes sense. To be able to program hardware USO, say.
>
> GSO on Rx is less obvious. Is this for HW-GRO? In general, some usage
> context will be helpful.
>
> Two implementation questions:
>
> - why define an XDP specific type for checksum types, but reuse the
>   netdev type for gso_type?
> - why u32 gso_type, when it is a u8 in skb_shared_info?
>
> > Please also don't post v3 yet and allow at least a week for the initial
> > reviewers to catch up..
>
>
>