netdev - Re: [PATCH net-next v2 05/18] xdp, xsk: constify read-only arguments of some static inline helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <674d6cae-b995-4020-9166-bb9309267448@intel.com>
Date: Mon, 21 Oct 2024 15:57:16 +0200
From: Alexander Lobakin <aleksander.lobakin@...el.com>
To: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
CC: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
	<edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Toke Høiland-Jørgensen
	<toke@...hat.com>, Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann
	<daniel@...earbox.net>, John Fastabend <john.fastabend@...il.com>, "Andrii
 Nakryiko" <andrii@...nel.org>, Stanislav Fomichev <sdf@...ichev.me>, "Magnus
 Karlsson" <magnus.karlsson@...el.com>,
	<nex.sw.ncis.osdt.itp.upstreaming@...el.com>, <bpf@...r.kernel.org>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v2 05/18] xdp, xsk: constify read-only arguments
 of some static inline helpers

From: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
Date: Thu, 17 Oct 2024 13:14:22 +0200

> On Tue, Oct 15, 2024 at 04:53:37PM +0200, Alexander Lobakin wrote:
>> Lots of read-only helpers for &xdp_buff and &xdp_frame, such as getting
>> the frame length, skb_shared_info etc., don't have their arguments
>> marked with `const` for no reason. Add the missing annotations to leave
>> less place for mistakes and more for optimization.
> 
> Same comment as in previous patch.
> Good stuff regardless.

Same comment as in the reply to the previous patch :D

Thanks,
Olek