netdev - Re: [PATCH net-next v2 13/18] xsk: allow attaching XSk pool via xdp_rxq_info_reg_mem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <516423c0-3be0-4ed4-9817-16ec276c16e6@intel.com>
Date: Mon, 21 Oct 2024 16:23:37 +0200
From: Alexander Lobakin <aleksander.lobakin@...el.com>
To: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
CC: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
	<edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Toke Høiland-Jørgensen
	<toke@...hat.com>, Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann
	<daniel@...earbox.net>, John Fastabend <john.fastabend@...il.com>, "Andrii
 Nakryiko" <andrii@...nel.org>, Stanislav Fomichev <sdf@...ichev.me>, "Magnus
 Karlsson" <magnus.karlsson@...el.com>,
	<nex.sw.ncis.osdt.itp.upstreaming@...el.com>, <bpf@...r.kernel.org>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v2 13/18] xsk: allow attaching XSk pool via
 xdp_rxq_info_reg_mem_model()

From: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
Date: Thu, 17 Oct 2024 14:49:51 +0200

> On Tue, Oct 15, 2024 at 04:53:45PM +0200, Alexander Lobakin wrote:
>> When you register an XSk pool as XDP Rxq info memory model, you then
>> need to manually attach it after the registration.
>> Let the user combine both actions into one by just passing a pointer
>> to the pool directly to xdp_rxq_info_reg_mem_model(), which will take
>> care of calling xsk_pool_set_rxq_info(). This looks similar to how a
>> &page_pool gets registered and reduce repeating driver code.
>>
>> Signed-off-by: Alexander Lobakin <aleksander.lobakin@...el.com>
> 
> Makes sense, but why not address callsites in drivers while at it?
> Otherwise in case this would be merged this would be called twice. Not a
> big deal though.

You said yourself that this series is big enough already :D
This won't be called twice as here I call it only when
`allocator != NULL`, but all the callsites pass NULL when they
want to register an XSk pool. It's not NULL only in case of
Page Pool.

> 
> Acked-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>

Thanks,
Olek