netdev - Re: [PATCH net-next 05/15] net: sparx5: add registers required by lan969x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241021193348.7a2423db@device-21.home>
Date: Mon, 21 Oct 2024 19:33:48 +0200
From: Maxime Chevallier <maxime.chevallier@...tlin.com>
To: Daniel Machon <daniel.machon@...rochip.com>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
 <pabeni@...hat.com>, <andrew@...n.ch>, Lars Povlsen
 <lars.povlsen@...rochip.com>, Steen Hegelund
 <Steen.Hegelund@...rochip.com>, <horatiu.vultur@...rochip.com>,
 <jensemil.schulzostergaard@...rochip.com>,
 <Parthiban.Veerasooran@...rochip.com>, <Raju.Lakkaraju@...rochip.com>,
 <UNGLinuxDriver@...rochip.com>, Richard Cochran <richardcochran@...il.com>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, <jacob.e.keller@...el.com>,
 <ast@...erby.net>, <netdev@...r.kernel.org>,
 <linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
 <devicetree@...r.kernel.org>
Subject: Re: [PATCH net-next 05/15] net: sparx5: add registers required by
 lan969x

Hello Daniel,

On Mon, 21 Oct 2024 15:58:42 +0200
Daniel Machon <daniel.machon@...rochip.com> wrote:

> Lan969x will require a few additional registers for certain operations.
> Some are shared, some are not. Add these.
> 
> Reviewed-by: Steen Hegelund <Steen.Hegelund@...rochip.com>
> Signed-off-by: Daniel Machon <daniel.machon@...rochip.com>

[...]

> +#define PTP_PTP_TWOSTEP_STAMP_SUBNS_STAMP_SUB_NSEC GENMASK(7, 0)

I understand that this is partly autogenerated, however the naming for
this register in particular seems very redundant... Is there any way
this could be improved ?

Thanks,

Maxime