netdev - Re: [PATCH] selftests: tc-testing: Fixed typo error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9e7df8d1-b7d9-41be-a65d-cfcd81e7e24a@linuxfoundation.org>
Date: Mon, 21 Oct 2024 14:20:32 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Karan Sanghavi <karansanghvi98@...il.com>,
 Jamal Hadi Salim <jhs@...atatu.com>, Cong Wang <xiyou.wangcong@...il.com>,
 Jiri Pirko <jiri@...nulli.us>, Shuah Khan <shuah@...nel.org>
Cc: netdev@...r.kernel.org, linux-kselftest@...r.kernel.org,
 linux-kernel@...r.kernel.org, Anup <anupnewsmail@...il.com>,
 Simon Horman <horms@...nel.org>, Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] selftests: tc-testing: Fixed typo error

On 10/19/24 05:52, Karan Sanghavi wrote:
> Corrected the multiple and different typo errors in json files
> 

It should say "Correct or Fix" - Same comment in short log
"Fix" instead of "Fixed"

Do refer to commit for the subsystems and file to get an idea
on the convention.

> - "diffferent" is corrected to "different".
> - "muliple" and "miltiple" is corrected to "multiple".
> 
> Signed-off-by: Karan Sanghavi <karansanghvi98@...il.com>
> ---
>   tools/testing/selftests/tc-testing/tc-tests/filters/basic.json  | 6 +++---
>   tools/testing/selftests/tc-testing/tc-tests/filters/cgroup.json | 6 +++---
>   tools/testing/selftests/tc-testing/tc-tests/filters/flow.json   | 2 +-
>   tools/testing/selftests/tc-testing/tc-tests/filters/route.json  | 2 +-
>   4 files changed, 8 insertions(+), 8 deletions(-)
> 

Otherwise the changes look good to me. With the above change
to short and commit logs:

Reviewed-by: Shuah Khan <skhan@...uxfoundation.org>

thanks,
-- Shuah