netdev - Re: [PATCH net-next] net: bnxt: use ethtool string helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACKFLin_iCLiHvHqkSspgYpNfBH_SWZ2DiLWW91EsAo5JAGaPA@mail.gmail.com>
Date: Mon, 21 Oct 2024 15:19:16 -0700
From: Michael Chan <michael.chan@...adcom.com>
To: Rosen Penev <rosenp@...il.com>
Cc: netdev@...r.kernel.org, Andrew Lunn <andrew+netdev@...n.ch>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next] net: bnxt: use ethtool string helpers

On Mon, Oct 21, 2024 at 2:05 PM Rosen Penev <rosenp@...il.com> wrote:
> The only real way to satisfy everything is to use a temporary variable like
>
> for (i = 0; i < BNXT_NUM_PORT_STATS; i++) {
>   const char *str = bnxt_port_stats_arr[i].string;
>
>   ethtool_puts(&buf, str);
>   }
>
> to make everything small.

This looks fine too.  The actual function call looks clean on one line.

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)