netdev - Re: [PATCH net] ipv4: ip_tunnel: Fix suspicious RCU usage warning in ip_tunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANn89iJr6dte1Eu40C9Z8KQ_gT2b2ETQdaTTrFtT0B8LjvP6vw@mail.gmail.com>
Date: Tue, 22 Oct 2024 11:17:02 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: Ido Schimmel <idosch@...dia.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org, 
	pabeni@...hat.com, dsahern@...nel.org, horms@...nel.org, pshelar@...ira.com
Subject: Re: [PATCH net] ipv4: ip_tunnel: Fix suspicious RCU usage warning in ip_tunnel_find()

On Tue, Oct 22, 2024 at 10:55 AM Ido Schimmel <idosch@...dia.com> wrote:
>
> On Tue, Oct 22, 2024 at 09:26:11AM +0200, Eric Dumazet wrote:
> > I was looking at this recently, and my thinking is the following :
> >
> > 1) ASSERT_RTNL() is adding code even on non debug kernels.
> >
> > 2) It does not check if the current thread is owning the RTNL mutex,
> > only that _some_ thread is owning it.
> >
> > I would think that using lockdep_rtnl_is_held() would be better ?
>
> Yes, agree. I see I did the same thing in 7f6f32bb7d335. Will post v2
> tomorrow unless you prefer to submit it yourself (I don't mind).

Please send your v2, thanks Ido !