netdev - RE: [PATCH v1 net-next 1/3] net: ena: Add PHC support in the ENA driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cd78a56636034961997214e418747d77@amazon.com>
Date: Tue, 22 Oct 2024 14:22:30 +0000
From: "Arinzon, David" <darinzon@...zon.com>
To: Simon Horman <horms@...nel.org>
CC: David Miller <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, Eric Dumazet
	<edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, "Woodhouse, David"
	<dwmw@...zon.co.uk>, "Machulsky, Zorik" <zorik@...zon.com>, "Matushevsky,
 Alexander" <matua@...zon.com>, "Bshara, Saeed" <saeedb@...zon.com>, "Wilson,
 Matt" <msw@...zon.com>, "Liguori, Anthony" <aliguori@...zon.com>, "Bshara,
 Nafea" <nafea@...zon.com>, "Schmeilin, Evgeny" <evgenys@...zon.com>,
	"Belgazal, Netanel" <netanel@...zon.com>, "Saidi, Ali" <alisaidi@...zon.com>,
	"Herrenschmidt, Benjamin" <benh@...zon.com>, "Kiyanovski, Arthur"
	<akiyano@...zon.com>, "Dagan, Noam" <ndagan@...zon.com>, "Bernstein, Amit"
	<amitbern@...zon.com>, "Agroskin, Shay" <shayagr@...zon.com>, "Abboud, Osama"
	<osamaabb@...zon.com>, "Ostrovsky, Evgeny" <evostrov@...zon.com>, "Tabachnik,
 Ofir" <ofirt@...zon.com>, "Machnikowski, Maciek" <maciek@...hnikowski.net>
Subject: RE: [PATCH v1 net-next 1/3] net: ena: Add PHC support in the ENA driver

> > The ENA driver will be extended to support the new PHC feature using
> > ptp_clock interface [1]. this will provide timestamp reference for
> > user space to allow measuring time offset between the PHC and the
> > system clock in order to achieve nanosecond accuracy.
> >
> > [1] - https://www.kernel.org/doc/html/latest/driver-api/ptp.html
> >
> > Signed-off-by: Amit Bernstein <amitbern@...zon.com>
> > Signed-off-by: David Arinzon <darinzon@...zon.com>
> 
> Hi David,
> 
> As it looks like there will be a v2 anyway, please consider running this series,
> and in particular this patch, through:
> 
> ./scripts/checkpatch.pl --strict --max-line-length=80 --codespell
> 
> And please fix warnings it emits where that can be done without reducing
> readability and clarity. E.g. please don't split string literals across more than
> one line just to make lines short.
> 
> Thanks!

Thanks Simon,
We'll resolve the issues in the next patchset.