netdev - Re: [PATCH] wifi: wilc1000: Add proper error handling for remaining CMD52

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f95fc508-fe6f-4501-9233-07bda0d28d98@denx.de>
Date: Tue, 22 Oct 2024 15:23:33 +0200
From: Marek Vasut <marex@...x.de>
To: Alexis Lothoré <alexis.lothore@...tlin.com>,
 linux-wireless@...r.kernel.org
Cc: "David S. Miller" <davem@...emloft.net>,
 Adham Abozaeid <adham.abozaeid@...rochip.com>,
 Ajay Singh <ajay.kathat@...rochip.com>,
 Claudiu Beznea <claudiu.beznea@...on.dev>, Conor Dooley
 <conor+dt@...nel.org>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Kalle Valo <kvalo@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Rob Herring <robh@...nel.org>, devicetree@...r.kernel.org,
 netdev@...r.kernel.org
Subject: Re: [PATCH] wifi: wilc1000: Add proper error handling for remaining
 CMD52

On 10/22/24 11:11 AM, Alexis Lothoré wrote:

Hi,

>> diff --git a/drivers/net/wireless/microchip/wilc1000/sdio.c b/drivers/net/wireless/microchip/wilc1000/sdio.c
>> index 5262c8846c13d..170470d1c2092 100644
>> --- a/drivers/net/wireless/microchip/wilc1000/sdio.c
>> +++ b/drivers/net/wireless/microchip/wilc1000/sdio.c
>> @@ -769,8 +769,10 @@ static int wilc_sdio_init(struct wilc *wilc, bool resume)
>>   
>>   static int wilc_sdio_read_size(struct wilc *wilc, u32 *size)
>>   {
>> -	u32 tmp;
>> +	struct sdio_func *func = dev_to_sdio_func(wilc->dev);
>>   	struct sdio_cmd52 cmd;
>> +	u32 tmp;
>> +	int ret;
>>   
>>   	/**
>>   	 *      Read DMA count in words
>> @@ -780,12 +782,20 @@ static int wilc_sdio_read_size(struct wilc *wilc, u32 *size)
>>   	cmd.raw = 0;
>>   	cmd.address = WILC_SDIO_INTERRUPT_DATA_SZ_REG;
>>   	cmd.data = 0;
>> -	wilc_sdio_cmd52(wilc, &cmd);
>> +	ret = wilc_sdio_cmd52(wilc, &cmd);
>> +	if (ret) {
>> +		dev_err(&func->dev, "Fail cmd 52, set DATA_SZ[0] register...\n");
> 
> I don't get the log message, why "set" DATA_SZ[0] ? This helper is rather trying
> to read it. Same for the other logs added below
Fixed in V2 , s@set@get@ , thanks !